Fix flaky test on-window, remove duplicate expect on-document (#58181)

WordPress · Jan 24, 2024 · 6e71cc2 · 6e71cc2
1 parent 01fb505
commit 6e71cc2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/test/e2e/specs/interactivity/directive-on-document.spec.ts b/test/e2e/specs/interactivity/directive-on-document.spec.ts
@@ -46,7 +46,6 @@ test.describe( 'data-wp-on-document', () => {
 		// Add the element back.
 		await visibilityButton.click();
 		await expect( counter ).toHaveText( '1' );
-		await expect( counter ).toHaveText( '1' );
 
 		// Wait until the effects run again.
 		await expect( isEventAttached ).toHaveText( 'yes' );

diff --git a/test/e2e/specs/interactivity/directive-on-window.spec.ts b/test/e2e/specs/interactivity/directive-on-window.spec.ts
@@ -29,16 +29,27 @@ test.describe( 'data-wp-on-window', () => {
 		page,
 	} ) => {
 		const counter = page.getByTestId( 'counter' );
+		const isEventAttached = page.getByTestId( 'isEventAttached' );
 		const visibilityButton = page.getByTestId( 'visibility' );
+
+		await expect( counter ).toHaveText( '0' );
+		await expect( isEventAttached ).toHaveText( 'yes' );
 		await page.setViewportSize( { width: 600, height: 600 } );
 		await expect( counter ).toHaveText( '1' );
+
 		// Remove the element.
 		await visibilityButton.click();
+
 		// This resize should not increase the counter.
 		await page.setViewportSize( { width: 300, height: 600 } );
+
 		// Add the element back.
 		await visibilityButton.click();
 		await expect( counter ).toHaveText( '1' );
+
+		// Wait until the effects run again.
+		await expect( isEventAttached ).toHaveText( 'yes' );
+
 		await page.setViewportSize( { width: 200, height: 600 } );
 		await expect( counter ).toHaveText( '2' );
 	} );