Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Fix flaky test on-window, remove duplicate expect on-document. #58181

Merged
merged 1 commit into from Jan 24, 2024

Conversation

cbravobernal
Copy link
Contributor

What?

Fixes #57983

Removes duplicate assertion spotted in #58008 (comment)

@cbravobernal cbravobernal added [Type] Bug An existing feature does not function as intended [Packages] Interactivity /packages/interactivity labels Jan 24, 2024
@cbravobernal cbravobernal self-assigned this Jan 24, 2024
Copy link

Flaky tests detected in 197ab8f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7640577286
📝 Reported issues:

@luisherranz luisherranz added [Type] Flaky Test Auto-generated flaky test report issue [Feature] Interactivity API API to add frontend interactivity to blocks. and removed [Type] Bug An existing feature does not function as intended labels Jan 24, 2024
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Type] Flaky Test, [Feature] Interactivity API, [Packages] Interactivity.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see if this time it's for real 😄

@luisherranz luisherranz added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 24, 2024
@luisherranz luisherranz merged commit 6e71cc2 into trunk Jan 24, 2024
62 of 65 checks passed
@luisherranz luisherranz deleted the fix/data-wp-on-window-flaky-test-v2 branch January 24, 2024 13:43
@luisherranz luisherranz removed the [Type] Code Quality Issues or PRs that relate to code quality label Jan 24, 2024
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky Test] the event listener is removed when the element is removed
2 participants