Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlighting bold/italic/links text doesn't invert text color with dark-editor-style #10550

Closed
slimmilkduds opened this issue Oct 12, 2018 · 5 comments
Labels
Needs Technical Feedback Needs testing from a developer perspective.

Comments

@slimmilkduds
Copy link

Describe the bug
Selecting for example a paragraph that is bold/italic/link almost makes the text invisible

To Reproduce
Steps to reproduce the behavior:

  1. create paragraph
  2. select some text and make it bold

Screenshots
screen shot 2018-10-12 at 13 57 21

Desktop (please complete the following information):

  • chrome
  • GB RC 4.0
@designsimply
Copy link
Member

Noting that testing steps to add dark editor style support are in #9683.

@designsimply designsimply added the Needs Technical Feedback Needs testing from a developer perspective. label Oct 16, 2018
@slimmilkduds
Copy link
Author

I'm not sure I'm doing something wrong, I always though that I had dark-editor-style activated but now I'm not so sure since I can't tell the difference after de-activating it. This is how I set it up:

function navi_gutenberg_styles() {
wp_enqueue_style( 'navi-gutenberg', get_theme_file_uri( '/style-editor.css' ), false, '1.0', 'all' );
}
add_action( 'enqueue_block_editor_assets', 'navi_gutenberg_styles' );

add_theme_support( 'editor-styles' );
add_theme_support( 'dark-editor-style' );

@slimmilkduds
Copy link
Author

slimmilkduds commented Oct 16, 2018

I've also tried this with the same result:

function mytheme_block_editor_styles() {
wp_enqueue_style( 'mytheme-block-editor-styles', get_theme_file_uri( '/style-editor.css' ), false, '1.0', 'all' );
}

add_action( 'enqueue_block_editor_assets', 'mytheme_block_editor_styles' );

add_theme_support( 'editor-styles' );
add_theme_support( 'dark-editor-style' );

The style-editor.css works in both cases but I get no visual change with add_theme_support( 'dark-editor-style' );

@slimmilkduds
Copy link
Author

Oh wait, it's actually working. But the problem in the ticket title still exists, this is a comparison between selecting bold and non-bold text

screen shot 2018-10-16 at 08 31 11 1

screen shot 2018-10-16 at 08 31 03

@slimmilkduds
Copy link
Author

This has been fixed in 4.1 rc 2 (or 1). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Technical Feedback Needs testing from a developer perspective.
Projects
None yet
Development

No branches or pull requests

2 participants