Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block media link #11046

Closed
Rahe opened this issue Oct 25, 2018 · 0 comments
Closed

Image block media link #11046

Rahe opened this issue Oct 25, 2018 · 0 comments
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@Rahe
Copy link
Contributor

Rahe commented Oct 25, 2018

Describe the bug
The image block link option links to the thumbnail selected, not the original image.
This doesn't allow to make lightbox behaviour for example, and this was the classic editor behaviour.

To Reproduce
Steps to reproduce the behavior:

  1. Go to an article
  2. Insert one image
  3. Select on right panel a thumbnail for the display
  4. On the "Link settings" select Media file

Expected behavior
The source media url is used instead of the thumbnail.

Desktop (please complete the following information):

  • OS: OSX
  • Browser : chrome
  • Version : last

Just changing the line

href = this.props.attributes.url;
to use the source_image can fix the issue in my opinion.

@earnjam earnjam added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Oct 30, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants