New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use source_url for media file link URL in image block #11254

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@earnjam
Contributor

earnjam commented Oct 30, 2018

Description

When inserting an image with the image block, you can set its link to "Media file". In the Classic Editor, this has traditionally been the original full-size image. In Gutenberg currently, this ends up just pointing to the file for the size of the image that is inserted into the post.

For example, if you insert the thumbnail size and select Media file for the link, it will just link to the thumbnail. That's not particularly helpful, since it's already loaded in the post body.

This PR just switches the link to use the original source_url for the image instead of the URL for the same size that is inserted into the post.

Fixes: #11046

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@jorgefilipecosta

LGTM 👍 Thank you for iterating on this change.

@earnjam earnjam merged commit 5bdaf3b into master Nov 1, 2018

2 checks passed

codecov/project 48.63% remains the same compared to 3add7c1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

daniloercoli added a commit that referenced this pull request Nov 1, 2018

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/port-quote-block-step-1

* 'master' of https://github.com/WordPress/gutenberg: (22 commits)
  Add removed periods to block descriptions. (#11367)
  Remove findDOMNode usage from the inserter (#11363)
  Remove deprecated componentWillReceiveProps from TinyMCE component (#11368)
  Create file blocks when dropping multiple files at once (#11297)
  Try avoiding the deprecated findDOMNode API from DropZone Provider (#11168)
  Fix: make meta+A behaviour of selecting all blocks work on safari and firefox. (#8180)
  Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets (#11342)
  Remove the Cloudflare warning (#11350)
  Image Block: Use source_url for media file link (#11254)
  Enhance styling of nextpage block using the Hr element (#11354)
  Embed block refactor and tidy (#10958)
  Nonce Middleware: Wrap the nonce middleware function into it's own function that isn't regenerated on every API request. (#11347)
  Fix RTL block alignments (#11293)
  RichText: fix buggy enter/delete behaviour (#11287)
  Remove code coverage setup (#11198)
  Parser: Runs all parser implementations against the same tests (#11320)
  Stop trying to autosave when title and classic block content both are empty. (#10404)
  Fix "Mac OS" typo + use fancy quotes consistently (#11310)
  Update documentation link paths (#11324)
  Editor: Reshape blocks state under own key (#11315)
  ...

# Conflicts:
#	gutenberg-mobile

antpb added a commit to antpb/gutenberg that referenced this pull request Nov 5, 2018

Image Block: Use source_url for media file link (WordPress#11254)
* Use source_url for media file link URL in image block

* Account for external images in media file link

@mtias mtias deleted the 11046-fix-image-link-source branch Nov 12, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Image Block: Use source_url for media file link (WordPress#11254)
* Use source_url for media file link URL in image block

* Account for external images in media file link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment