Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Document and Block tabs aria-labels for better translations and a11y #11617

Closed
afercia opened this issue Nov 8, 2018 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Copy Issues or PRs that need copy editing assistance

Comments

@afercia
Copy link
Contributor

afercia commented Nov 8, 2018

screenshot 2018-11-08 at 12 14 05

See
Success Criterion 2.5.3 Label in Name
https://www.w3.org/TR/WCAG21/#label-in-name

It's recommended to craft aria-labels in a way that they start with the same word used in the visible label. This way, speech input users have a chance to voice a proper command.

When the user locale is set to English, the visible label and aria-labels used on these tabs meet the requirement:

Document
Document settings

Block
Block settings

However, when translated in other languages, there's no guarantee the aria-labels will start with "Document" or "Block". For example, in Italian they're translated this way:

Documento
Impostazioni del documento

Blocco
Impostazioni blocco

There's really no other way to translate them, inverting the word orders wouldn't make sense. In this case, a speech input user would voice a command "click Documento" and the command will fail because the accessible name of the control is different: "Impostazioni del documento".

I'd like to propose to remove the word "settings" from all these strings and use them only to communicate the selected state.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Copy Issues or PRs that need copy editing assistance labels Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

No branches or pull requests

1 participant