Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit Permalink #1285

Closed
maddisondesigns opened this issue Jun 20, 2017 · 70 comments
Closed

Can't edit Permalink #1285

maddisondesigns opened this issue Jun 20, 2017 · 70 comments

Comments

@maddisondesigns
Copy link

@maddisondesigns maddisondesigns commented Jun 20, 2017

After publishing the page, there's no option to allow you to edit your permalink. The only way you can edit the permalink is using the Quick Edit link on the page that lists all your Posts.

Sometimes people make mistakes when adding your page title. If you've published the page, you need to be able to edit the Permalink because simply changing the page title wont change it.

@paaljoachim

This comment has been minimized.

Copy link

@paaljoachim paaljoachim commented Jun 20, 2017

An edit button will be added beside the copy permalink button. (I do not know why it is not added yet.) Thanks for bringing it up!

@maddisondesigns

This comment has been minimized.

Copy link
Author

@maddisondesigns maddisondesigns commented Jun 20, 2017

Great to hear, but where's the copy permalink button? I don't see that anywhere either. I presume that also needs to be added.

@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jun 20, 2017

Discussing in #1042 (comment)

@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jun 20, 2017

The permalink UI shows up when you've saved your post, and click the title.

Considering this seems to be causing some discoverability issues, we should revisit this.

@jasmussen jasmussen added the Design label Jun 20, 2017
@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jun 20, 2017

Here's a mockup for the current behavior:

permalink

Here's an older mockup:

permalink older

@maddisondesigns

This comment has been minimized.

Copy link
Author

@maddisondesigns maddisondesigns commented Jun 20, 2017

Ahhh ok. Yeah, that's not very Intuitive. No-one will find that. At least, not on purpose anyway.

It would be much better if the Permalink was on display all the time, in a similar position to what it currently is.

You could show it slightly fainter when people are editing their content.

gutenberg-permalink

When hovering your cursor over it, that's when you'd show the Copy & Edit button, and make it slightly darker.

gutenberg-permalink-hover

@buzztone

This comment has been minimized.

Copy link

@buzztone buzztone commented Jun 20, 2017

It would be much better if the Permalink was on display all the time, in a similar position to what it currently is.

Interested to hear why you feel this information should be displayed permanently.

For me it's something I only want to see when I want to edit it. I've always found its display in the current WP UI annoying.

Also showing the Permalink when I click on the Title to edit it seemed natural & obvious to me.

@maddisondesigns

This comment has been minimized.

Copy link
Author

@maddisondesigns maddisondesigns commented Jun 20, 2017

@buzztone Personally, I like to know the URL that's generated when I save a page. It's annoying that it's been hidden and it's not intuitive, the way it is at the moment. It doesn't even show when you hover your cursor over the page title, you have to actually click on it for it to display. You don't have to click on the Page title on the existing edit screens to be able to view the Permalink. It's just there. I know I certainly didn't think to click on the page title to view it.

From an SEO perspective, plugins like Yoast provide the option to automatically remove stopwords from your slugs. Sometimes though, it's more useful to actually keep these words in as it provides a more user readable URL, depending on the page. These stopwords are obviously only going to be removed once the permalink is generated so it's an extra step that you have to take, clicking on the page title to check the url, rather than just being able to see it there.

Not only that, having the URL on display acts as a convenient link to the page preview (and yes, I realise there's a Preview button. There's also a Preview button on the existing editor screens). Also, the Permalink shows on the current Post/Page edit pages. This new editing experience is going to be confusing for some people, removing/hiding too many of the existing features is just going to make it even more confusing for them.

@buzztone

This comment has been minimized.

Copy link

@buzztone buzztone commented Jun 20, 2017

It doesn't even show when you hover your cursor over the page title

Showing the Permalink when you hover over the Title would I believe provide a sufficiently strong similarity to the existing UI to avoid confusion among existing users, if that is considered worthwhile.

@maddisondesigns

This comment has been minimized.

Copy link
Author

@maddisondesigns maddisondesigns commented Jun 21, 2017

@buzztone That would certainly be an improvement, than having to click on it. Interested to know why you don't want it on display all the time.

@buzztone

This comment has been minimized.

Copy link

@buzztone buzztone commented Jun 21, 2017

Interested to know why you don't want it on display all the time.

I see the Gutenberg Editor creating an entirely new editing experience for WordPress which is very different from the current editor & much more user friendly, particularly for novice users.

In this context I see the permanent display of the Permalink as a historical artifact.

To me it's an ancillary part of the editing process. I don't see it as any more significant than the other overall post info such as Status, Visibility, Published on etc. which are included in Post Settings.

Personally I'd be happy to see the Permalink only in Post Settings but I understand the need to include it in roughly its current location to help existing users find it easily.

@ntwb

This comment has been minimized.

Copy link
Member

@ntwb ntwb commented Jun 21, 2017

I'm also erring on the side of having the ability to always see the permalink.

An example where I see it being beneficial is with hierarchical post types, the URL makes for a quick visual reference of where a page is located in the the page hierarchy...

@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jun 21, 2017

It seems like there's a wide agreement that we want to find a considered place for the permalink. One that isn't visible in a mystery meat kind of way, but also one that isn't intrusive.

How about we revisit the basic design pattern of the blocks, and look at a different way of surfacing things. Right now the mockups for the block looks like this:

screen shot 2017-06-21 at 10 01 12

The mover on the left, and the advanced buttons on the right show up on hover. We could leverage that pattern.

Hover over the title:

screen shot 2017-06-21 at 10 03 29

Click the link icon:

screen shot 2017-06-21 at 10 05 51

Alternately if we want it still more visible, we could just always show the link icon next to the title. This is what we do on WordPress.com, and it's working well:

screen shot 2017-06-21 at 10 06 51

@maddisondesigns

This comment has been minimized.

Copy link
Author

@maddisondesigns maddisondesigns commented Jun 21, 2017

@jasmussen I like the suggestion of showing the link icon next to the title. It keeps a clear indicator of the page link visible, whilst also keeping it fairly minimal and unobtrusive.

@buzztone

This comment has been minimized.

Copy link

@buzztone buzztone commented Jun 21, 2017

The link icon makes its purpose very clear but is also minimal and unobtrusive.

Showing the link icon permanently next to the title also has the advantage of distinguishing the Title block from other blocks.

I personally found the visual similarity with Header blocks confusing. I initially thought it was a Header and was confused by what I saw in Post Settings.

I do think its important to make clear to users that this block is the Title.

@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jun 21, 2017

Seems like we have some consensus here. Let's try this pattern then.

@aduth

This comment has been minimized.

Copy link
Member

@aduth aduth commented Jun 21, 2017

Related: #577

@paaljoachim

This comment has been minimized.

Copy link

@paaljoachim paaljoachim commented Jun 21, 2017

I agree having the link icon to the left of the title show up on hover seems nice and non-obtrusive. It creates a clear difference from the title and a regular block.

@mtias mtias added this to the Beta 2 milestone Jun 22, 2017
@GaryJones

This comment has been minimized.

Copy link
Contributor

@GaryJones GaryJones commented Jun 22, 2017

I like the link icon, but also feel the slug may better be changed within the context of the Post Settings tab, rather than floating somewhere in the editor (easier for mobile users?).

@mtias mtias removed this from the Beta 2 milestone Jun 22, 2017
@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jun 23, 2017

The only problem with moving it to post settings is that it removes it for people who decide to dismiss the post settings box on desktop (for immersivenes), and hides it behind a cog on mobile.

@GaryJones

This comment has been minimized.

Copy link
Contributor

@GaryJones GaryJones commented Jun 23, 2017

The only problem with moving it to post settings is that it removes it for people who decide to dismiss the post settings box on desktop (for immersivenes), and hides it behind a cog on mobile.

Right - but this is a value that is:

  • automatically set to a usually somewhat sensible default by WP.
  • only typically changed, if at all, once per post.

This occasional action, doesn't need to be permanently displayed. To me, it falls under the same type of ready-to-publish settings as changing the publish date, or status, or author, or setting a password.

@tonyzeoli

This comment has been minimized.

Copy link

@tonyzeoli tonyzeoli commented Jun 24, 2017

I'm running a multisite network with one test site. I see the Permalink hover over the Post Title, however, I do not see the Edit button.

https://cloudup.com/cOr7M0eQfNB

Also, the Permalink itself does not display the resulting words in the URL. It still displays the query ID.

@folletto

This comment has been minimized.

Copy link

@folletto folletto commented Jul 3, 2017

I like the link icon, but also feel the slug may better be changed within the context of the Post Settings tab, rather than floating somewhere in the editor (easier for mobile users?).

The only problem with moving it to post settings is that it removes it for people who decide to dismiss the post settings box on desktop (for immersivenes), and hides it behind a cog on mobile.

I'd consider too in adding it to the sidebar inspector when no item is selected or the publish panel dropdown.

This because:

  1. The URL is a "page-level" thing, not related to a specific block. It's higher in the IA hierarchy.
  2. The title might not be there in the future (as it's going to be "just a block" for title-less posts, so we shouldn't tie it to the title.
  3. It's an advanced feature: a user that just posts without the sidebar open can just write and publish.
  4. It's not something one should care while writing, it's more related to publishing.
  5. As others said, doesn't have to be permanently displayed.
@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jul 3, 2017

What would it look like if the permalink was in the sidebar? Would it be its own panel, or could we put it in another?

@folletto

This comment has been minimized.

Copy link

@folletto folletto commented Jul 3, 2017

It's a good question. A new "URL" panel (with field, copy, and maybe a link to the permalink configuration page) seem making sense (as also could be extended by plugins to provide shortening features) — but I see also reasons for it to be inside others. "Discussion" as the URL is often shared, "Status" as it's a form of status.

Thinking again, it seems making more sense inside the Publish dropdown (#708) once it gets built?
(see also the more advanced proposal I mocked up a while ago for customizer here).

@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jul 3, 2017

I like the permalink in the dropdown idea very much.

@aduth

This comment has been minimized.

Copy link
Member

@aduth aduth commented Jan 2, 2018

Another note. If you edit the permalink in Quick Edit, Gutenberg will not recognize the new slug, and will instead always show the original slug.

Can you clarify the exact steps and expected outcome here? The way I'm reading this, it sounds like an issue with Quick Edit, if what you're saying is that the slug on the front-end of a site is not updated correctly after editing via Quick Edit on the posts list.

@amandablum

This comment has been minimized.

Copy link

@amandablum amandablum commented Jan 2, 2018

@aduth went to reproduce it and it has stopped happening, but I don't know why.... for a few weeks, this was happening, but I've updated Gutenberg and someother plugins since then.

  1. see permalink in gutenberg. can't edit it, so go to quick edit to change permalink.
  2. change permalink in quick edit. save.
  3. return to page in gutenberg, link has not changed to reflect quick edit.
  4. try permalink from gutenberg and quick edit (because now they're different) and the quick edit link will work, gutenberg link will not.
  5. tried the permalink panel 2x save trick (hitting save on the permalink settings 2x from permalinks panel) to reset all the permalinks and this did not work.

again, seems to be working now.

@azaozz

This comment has been minimized.

Copy link
Contributor

@azaozz azaozz commented Jan 11, 2018

This issue seems to have run in many different directions. Going back to the main problem: in Gutenberg permalinks are not editable. Additionally there is no "sample permalink" shown for drafts.

Currently (on the old Edit Post screen) permalinks are always generated from PHP and shown with simple AJAX. This is needed as when generating new permalink WordPress looks at all published posts' "slugs" and if there is a match it appends -1 to the new permalink to avoid duplicates.

Because of that permalinks cannot be generated in JS/Gutenberg even if the permalink_structure option is known. This makes the above patch and https://core.trac.wordpress.org/ticket/42465 useless for this issue.

To be able to edit permalinks in Gutenberg, they will have to work similarly to how they work currently:

  • Permalinks are generated in PHP. This involves a database lookup and doesn't make sense to do remotely.
  • A sample permalink is generated as soon as the post title has been typed (on blur of the title field). It follows the same rules as "permanent" permalinks except that it may be overridden when publishing the post if another post with exactly the same title was published in the meantime.
  • When editing a permalink it has to be saved immediately and the returned result displayed as it may be different from what the user has typed. This allows for further edits until the user is happy with it.
@azaozz

This comment has been minimized.

Copy link
Contributor

@azaozz azaozz commented Jan 11, 2018

I'm also not particularly fond of the current location of the permalink field. I get it: permalinks are really important for good SEO, but still... All "post settings" are in the right sidebar, why is the permalink front and center on top of everything else? :) Also, it is currently covered by the "Post published! View post" notice:

gutenberg-permalink-on-published-1

I like the idea to have the permalink field where the rest of the settings are. Then when the AYS before publishing is shown, it would show the current "sample permalink" as a reminder to edit it if necessary (Don't think that AYS panel should duplicate the post settings, but that's another issue).

@afercia

This comment has been minimized.

Copy link
Contributor

@afercia afercia commented Jan 11, 2018

@azaozz, right: I think the logic for the unique "slug" is in wp_unique_post_slug() correct?

it is currently covered by the "Post published! View post" notice

Yep, it was noted on the PR: #3418 (comment)

@azaozz

This comment has been minimized.

Copy link
Contributor

@azaozz azaozz commented Jan 11, 2018

@afercia right, the "slug" is generated by wp_unique_post_slug() that runs DB queries in the process. There are also couple of filters in there: wp_unique_post_slug_is_bad_flat_slug and wp_unique_post_slug making it impossible to repeat the functionality in JS.

@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jan 15, 2018

Here are updated mockups for an improved permalink UI, based on #1285 (comment):

permalinks

permalinks-popout

Yes, there should be an "Edit" button there too.

Should this be a separate ticket to improve the UI, given this ticket is chiefly to add the Edit feature in the first place?

@karmatosed

This comment has been minimized.

Copy link
Member

@karmatosed karmatosed commented Jan 16, 2018

I am a little concerned we're duplicating work being done here: #3418. That may be wrong, but raising incase.

Does that need a redesign when we're working on that for now @jasmussen? My suggestion would be get the editable in and then we can iterate. This feels a better approach to this.

Let's maybe do this:

  • Make new issue for working on UI
  • Close this issue when the PR goes in for the other and/or close now as conversation is happening in both places.
@jasmussen

This comment has been minimized.

Copy link
Contributor

@jasmussen jasmussen commented Jan 17, 2018

Just to clarify — we need to make the permalink editable first. ANY improvements to the design can and should happen after that, and aren't even as high priority.

@pento pento closed this in #3418 Jan 24, 2018
schlessera added a commit that referenced this issue Mar 5, 2018
…ditable-permalinks-2

The previous pull-request under #3418 cannot be properly opened again to continue work on it, as it had been merged already.

This new PR continues work on solving #1285.

Please refer to #3418 for design mockups and prior history.
schlessera added a commit that referenced this issue Mar 5, 2018
…gement

* The modal is now a Popover to match the most recent design mockup in #1285.
* When the Popover is opened, the Copy button gets the focus by default, as the most sensible and safe default action.
* When the Edit button is clicked, the Permalink input field gets the focus.
* When the permalink change is saved, the Copy button again gets the focus.
schlessera added a commit that referenced this issue Mar 8, 2018
…gement

* The modal is now a Popover to match the most recent design mockup in #1285.
* When the Popover is opened, the Copy button gets the focus by default, as the most sensible and safe default action.
* When the Edit button is clicked, the Permalink input field gets the focus.
* When the permalink change is saved, the Copy button again gets the focus.
@irakligeek

This comment has been minimized.

Copy link

@irakligeek irakligeek commented Mar 8, 2018

I believe permalink should be visible and very intuitive to edit, as it is a huge part of every publishing company that actually cares about SEO.

@themightymo

This comment has been minimized.

Copy link

@themightymo themightymo commented Mar 26, 2018

So is there a way to edit a permalink with Gutenberg enabled? I can't find it...

@GlennMartin1

This comment has been minimized.

Copy link

@GlennMartin1 GlennMartin1 commented Mar 26, 2018

@themightymo As of Gutenberg 2.4, not yet.

Here's the active PR: #5756

@themightymo

This comment has been minimized.

Copy link

@themightymo themightymo commented Mar 26, 2018

@GlennMartin1 Thanks so much for pointing me there!

@parkerCHRLS

This comment has been minimized.

Copy link

@parkerCHRLS parkerCHRLS commented Apr 12, 2018

Would it be possible to have a Gutenberg config menu that allows users to choose what information to be "permanently displayed" such as permalink info custom fields etc...? I am enjoying writing within Gutenberg so far.

pento added a commit that referenced this issue Apr 15, 2018
What a wild ride. Thanks for the memories.

Closes #5414, #1285.
@ChrisChiera

This comment has been minimized.

Copy link

@ChrisChiera ChrisChiera commented Aug 7, 2018

Trying out Gutenberg for the first time, and clicked around on the sidebar, and the "..." and didn't find the edit/view permalink option anywhere. Thankfully searched here and found it. In it's current implementation certainly not intuitive location but hopefully changes are still being made in this regard to make it more intuitive for new users while also keeping the interface minimal.

@luc122c

This comment has been minimized.

Copy link

@luc122c luc122c commented Aug 13, 2018

I've just had my first proper play with Gutenberg today and this stumped me. I looked all over to try and change the slug.

Surely this is something that could go on the cog menu under document somewhere along with the Post Status and Visibility? Not once did I consider clicking the title, because it wasn't the title that I wanted to edit!

@jaclyntan

This comment has been minimized.

Copy link

@jaclyntan jaclyntan commented Aug 20, 2018

I too could not figure out where the permalink feature was until I came here. Even then there's no option to alter the slug once the post is published? Or has the feature not been implemented yet? (nvm figured it out...)
Design-wise it makes no sense to make it appear when you click on the title. Can the permalink block just be visible on all pages above the title?

@ernilambar

This comment has been minimized.

Copy link

@ernilambar ernilambar commented Aug 20, 2018

I had to Google How to change permalink in Gutenberg and came here to find out about editing permalink.

@maddisondesigns

This comment has been minimized.

Copy link
Author

@maddisondesigns maddisondesigns commented Aug 20, 2018

For those that have added a comment recently about not being able to find where to change the permalink, you might want to add a comment to #8949 as this issue that you've commented on (#1285), is currently closed.

@syamsulalam

This comment has been minimized.

Copy link

@syamsulalam syamsulalam commented Nov 9, 2018

I had to Google How to change permalink in Gutenberg and came here to find out about editing permalink.

Me too, i had to google "gutenberg slug quick edit" to arrive here to find ways to quick edit my slug. Anyone thinking to hide it must be so crazy he/she had to be tied down & slapped silly.

@asangam

This comment has been minimized.

Copy link

@asangam asangam commented Dec 12, 2018

Had to come here just to edit the permanlink. Clicking the title after saving didn't work for. I had to manually go to
image to make the changes. Any better way to quick edit? The most is i want to see what URL Wordpress gives after a page has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.