Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Block: Focus style for the button text is not clear #15051

Closed
kjellr opened this issue Apr 18, 2019 · 1 comment · Fixed by #15058
Closed

Button Block: Focus style for the button text is not clear #15051

kjellr opened this issue Apr 18, 2019 · 1 comment · Fixed by #15058
Labels
[Block] Buttons Affects the Buttons Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Apr 18, 2019

As noted by @afercia in #10128, the focus style of button text within the button block is not clear. In this GIF, you can see a very subtle cursor sitting in between the t and e of the placeholder text:

button-focus

This does not make it entirely clear that your focus is within the button, and that typing will add text to this area.

When you start typing, this blinking cursor is a little more evident:

button-focus-text

At a minimum, we should try to improve the visibility of the blinking cursor in the placeholder state, but I'd recommend we go further than that and sort out a stronger indicator of focus for the button as well.

@nfmohit
Copy link
Member

nfmohit commented Apr 18, 2019

I've started a PR for this here ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants