-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking into menu item shows border #18331
Comments
I'm a little lost here, so bear with me... If you're talking about the light grey border around the input field... that's necessary because it indicates an input field, but at the same time it's so light I can barely see it. My suggestion in this case is to keep the border around the input field and darken it for accessibility. However, if you're talking about the dotted border... that's actually the parent block's border and not the border of the individual item. It's hard to discern between the two because you've selected the first menu item. Clicking one of the others shows this relationship a bit better. Ultimately either case can use some design improvements. |
I am not sure if we need to treat the menu item as an input and add a border to it, because being a Rich Text you'd expect it to simply be editable text, not an input as there is no form to submit. I would remove the border altogether. |
I also feel it shouldn't be treated as input as we don't do this to typing area. |
The text is a Rich Text attribute, same as the text of a Button block, so shouldn't have any border unless it's part of the front-end design as well. The menu item as a whole should have a focus state (like when you press Escape). |
Good to know, thanks. It was introduced by me 🤦♂ btw it has been already fixed, already on master. |
Right now you see a border around the menu item when you click into it:
I would suggest having nothing is better?
The text was updated successfully, but these errors were encountered: