Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template navigation: Remove "All" panel #26925

Closed
jameskoster opened this issue Nov 12, 2020 · 7 comments
Closed

Template navigation: Remove "All" panel #26925

jameskoster opened this issue Nov 12, 2020 · 7 comments
Assignees
Labels
Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@jameskoster
Copy link
Contributor

The Templates panel in the navigation current includes a superfluous "All" section. Since all templates are listed already (albeit categorised), this section isn't helpful.

@Copons
Copy link
Contributor

Copons commented Nov 12, 2020

While the "all" section might not be helpful for the end-user, it's very useful for the development of the Site Editor.

I've got a PR open that improves the actual Templates wp-admin list to display all templates (right now it hides the theme-provided ones).
If/when that PR goes in, we'll have a good enough "source of truth" for templates, and I'd say we could remove the "all" section from the sidebar. 🙂

@jameskoster
Copy link
Contributor Author

Fair enough. Another condition upon which we might remove it is when all the other panels in the navigation have been built.

@jeyip
Copy link
Contributor

jeyip commented Nov 30, 2020

Adding some visuals for context:

2020-11-30 14 55 14

@Addison-Stavlo
Copy link
Contributor

Noting this may also require polishing up which templates show up in which sections of that menu. Currently from creating from the add template ("+") icon in the menu:

  • a Post template only seems to show up under the "All" menu.
  • Only Page ends up under the "Pages" menu. Front Page, Singular, Index do not - although Im not sure which should? 🤔

@jameskoster
Copy link
Contributor Author

although Im not sure which should? 🤔

I'm thinking the generic Page template should probably be top-level as it is one that folks are likely to interact with more frequently.

The "Pages" section could contain any page-specific (page-$id) templates.

@Addison-Stavlo
Copy link
Contributor

I'm thinking the generic Page template should probably be top-level as it is one that folks are likely to interact with more frequently.

I assume the same should be true about Post ?

@jameskoster
Copy link
Contributor Author

I think so, yes.

At this point it may be worth revisiting #26264 so that we don't end up clogging the top level too much.

@jameskoster jameskoster added the Needs Dev Ready for, and needs developer efforts label Jan 13, 2021
@mattwiebe mattwiebe self-assigned this Feb 5, 2021
mattwiebe added a commit that referenced this issue Feb 5, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 5, 2021
@vindl vindl closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants