Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets customizer panel: Too much padding above first block #38391

Closed
noisysocks opened this issue Feb 1, 2022 · 0 comments · Fixed by #38746
Closed

Widgets customizer panel: Too much padding above first block #38391

noisysocks opened this issue Feb 1, 2022 · 0 comments · Fixed by #38746
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

noisysocks commented Feb 1, 2022 •
edited

Description

In the Widgets customiser panel, there's too much padding above the first block. The block toolbar is supposed to sit evenly in between the first block and the customizer toolbar.

Step-by-step reproduction instructions

  1. Activate a classic theme.
  2. Go to Appearance → Customize → Widgets.
  3. Select the first block.
  4. Notice the extra padding in between the block toolbar and the customizer toolbar.

Screenshots, screen recording, code snippet

Screen Shot 2022-02-01 at 12 20 49

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@noisysocks noisysocks added [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Feb 1, 2022
Alex-Kostov added a commit to Alex-Kostov/gutenberg that referenced this issue Feb 11, 2022
@Alex-Kostov
Fix for widget customizer panel,
8e62b16 
Reduced the margin of the block toolbar
Fixes WordPress#38391
@Alex-Kostov Alex-Kostov mentioned this issue Feb 11, 2022
Merged
8 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 11, 2022
noisysocks added a commit that referenced this issue Feb 17, 2022
@Alex-Kostov @noisysocks
Fix for widget customizer panel, (#38746)
04ba33e 
* Fix for widget customizer panel,
Reduced the margin of the block toolbar
Fixes #38391

* Increase padding a little

* Dismiss block toolbar after opening inserter in customizing-widgets E2E tests

The block toolbar sometimes obscures buttons in the inserter causing
test failures. It's not clear whether this is desired behaviour or not.
For now, let's just work around it in the E2E test.

Co-authored-by: Robert Anderson <robert@noisysocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce the margin of the block toolbar. Alex-Kostov/gutenberg
1 participant
@noisysocks