Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the navigation block only contains a page list, there are no color options #41080

Closed
carolinan opened this issue May 16, 2022 · 2 comments · Fixed by #41114
Closed

When the navigation block only contains a page list, there are no color options #41080

carolinan opened this issue May 16, 2022 · 2 comments · Fixed by #41114
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@carolinan
Copy link
Contributor

Description

Using Wordpress 6.0 RC2, without or without Gutenberg current trunk,
I am seeing a regression in Twenty Twenty-two where the navigation block does not have color options if it only contains the page list block.

This is a problem because it means we cannot change the link color, and because there is a problem with the link color inheritance that makes the submenu item have white text on white background:
#40908

First I would appreciate a sanity check to confirm if this can be reproduced.

Step-by-step reproduction instructions

  1. Install the WordPress 6-0 nightly using the beta tester
  2. Open the Site Editor
  3. Select the navigation block: Don't customize the block, it should fall back to the markup in TT2:
<!-- wp:navigation {"layout":{"type":"flex","setCascadingProperties":true,"justifyContent":"right"}} -->
<!-- wp:page-list {"isNavigationChild":true,"showSubmenuIcon":true,"openSubmenusOnClick":false} /-->
<!-- /wp:navigation -->
  1. View the block settings sidebar, notice that the color options are missing.

Screenshots, screen recording, code snippet

Block sidebar settings, but without the color panel

Environment info

  • WordPress 6.0-RC2-53389
    -beta tester plugin
    With or without Gutenberg current trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@carolinan carolinan added [Type] Regression Related to a regression in the latest release [Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended labels May 16, 2022
@carolinan
Copy link
Contributor Author

Actually there are more panels missing than the colors.
-If I add a link menu item, and then remove it, the missing panels re-appear.

@draganescu
Copy link
Contributor

draganescu commented May 17, 2022

I tested this and it seems the color panel is missing only when the dafault markup menu is selecte. The same configuration manually built (a navigation block with a single page list block child shows the color options.

Later edit: the unsaved blocks output does not place the controls in the inspector. Working on a PR.

@draganescu draganescu self-assigned this May 17, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 17, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants