Add missing styling panels for uncontrolled navigation #41114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d blocks in navigation
draganescu
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
May 18, 2022
getdave
approved these changes
May 18, 2022
@carolinan is this only for uncontrolled menus (menus with items coming from theme files) or for all menus? |
adamziel
pushed a commit
that referenced
this pull request
May 20, 2022
…d blocks in navigation (#41114)
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 880c4cc |
adamziel
removed
the
Backport to WP Beta/RC
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 880c4cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41080
Why?
The menus that themes provide by default did not have styling UI in the inspector.
How?
The navigation block returned early the uncontrolled blocks but the styling inspector panels were not
part of the returned JSX.
Testing Instructions
(color, icon button, display settings)
Screenshots or screencast