Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensibility: Make it possible to add "Open in a new window", "nofollow" and other link options #4597

Closed
Soean opened this issue Jan 19, 2018 · 12 comments
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@Soean
Copy link
Member

Soean commented Jan 19, 2018

Issue Overview

The "Open in new window" link option was removed in #4583. For plugin authors it should be possible to add this function with a plugin.
This also can be useful for a "nofollow" option, see #4499

@Soean Soean added [Type] Enhancement A suggestion for improvement. [Feature] Extensibility The ability to extend blocks or the editing experience labels Jan 19, 2018
@StaggerLeee
Copy link

It should stay (open in new tab), at least as simple functions filter.
There are cases when needed. "Friends, Links, Portfolio" pages/templates.

Stupid to link to some donor/friend/sponsor and be navigated away from your website, just because of this courtesy link.

@danielbachhuber danielbachhuber changed the title Extensibility: Add link options Extensibility: Make it possible to add "Open in a new window", "nofollow" and other link options Jan 23, 2018
@paaljoachim
Copy link
Contributor

Hmm Open in a new window should stay as a option in the UI without having to add some extra code for it.
If it clutters the link interface then perhaps have the block setting change to reflect the selection of a link box. As additional options could then be shown in the Link setting.

@ellatrix
Copy link
Member

We could create a slot in the inspector that has formatting props from Editable and can then be filled by a plugin. So when you select a link for example, you'd see extra options in the block inspector.

In some cases it may be more interesting to filter the links with a the_content filter, based on the URL, template, etc.

@ellatrix ellatrix added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Jan 26, 2018
@gziolo gziolo added this to To do in Extensibility Jan 31, 2018
@dmccan
Copy link

dmccan commented Apr 7, 2018

Please consider adding the "Open in a new tab" option to the Gutenberg link interface. It is widely used. It is just a checkbox. It is common to use it on all external links.

@ellatrix
Copy link
Member

ellatrix commented Apr 7, 2018 via email

@dmccan
Copy link

dmccan commented Apr 7, 2018

It's an option of the current (classic) editor ... so it is not new behavior and apparently a normal enough option. It would be more convenient to have the checkbox near the URL entry box. I'm glad there is a PR. I'm not in a position to merge the pull request. Can you please do so?

@karmatosed
Copy link
Member

Closing as with latest version we're adding back in open in a new window.

Extensibility automation moved this from To do to Done Apr 10, 2018
@juicerocket
Copy link

Please add the nofollow option in the same format as the new window option. It's also important because Google and the FTC both require "nofollow" for any paid-for link (like blogs use, for influencer marketing). It's way too difficult to add that now, with Gutenberg. It should be a toggle option like the new window option.

@Natuurlijklinda
Copy link

The nofollow option is indeed very important! I hope it will be an option soon, since the Ultimate Nofollow plugin is not working with the new layout... The rest of the new layout works very nice (uptill now), so I actually want to use. But I need the nofollow option. :) As said above, it would be nice if it's the same as the "open in new window" toggle or something like that.

@designsimply
Copy link
Member

Noting that a new issue was created requesting the ability to add nofollow for links at #13542.

@StaggerLeee
Copy link

Is than "noopener" added automatically ?

@designsimply
Copy link
Member

designsimply commented Jan 29, 2019

@StaggerLeee I found an explanation about "noopener" at https://support.performancefoundry.com/article/186-noopener-noreferrer-on-my-links and, yes, the explanation mentions it was added in the Core project as of WP 4.7.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Extensibility
  
Done
Development

No branches or pull requests

9 participants