New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Open in new window" link option #4583

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
@iseulde
Member

iseulde commented Jan 18, 2018

Description

Fixes #4571. Reverts #2628.

How Has This Been Tested?

Ensure the link pop up has no advanced settings.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@iseulde iseulde requested review from karmatosed and notnownikki Jan 18, 2018

@notnownikki

🚀

@iseulde

This comment has been minimized.

Member

iseulde commented Jan 19, 2018

Thank you @notnownikki!

@iseulde iseulde merged commit 5ab37b7 into master Jan 19, 2018

3 checks passed

codecov/project 42.39% (+0.04%) compared to 6c256dd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@iseulde iseulde deleted the remove/target-blank branch Jan 19, 2018

schlessera added a commit that referenced this pull request Jan 23, 2018

Refresh patch
Squashed commit of the following:

commit 4e0358e
Merge: 5f6e8c6 73612cb
Author: Joen Asmussen <joen@automattic.com>
Date:   Tue Jan 23 11:19:02 2018 +0100

    Merge pull request #4631 from WordPress/try/new-mover-icons

    Try smaller up/down arrows, and focus management

commit 73612cb
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Tue Jan 23 10:28:59 2018 +0100

    Adjust test to not look for the icon

    The icon is now an SVG passed on

commit 5f6e8c6
Author: Herb Miller <herb@bobbingwide.com>
Date:   Tue Jan 23 04:06:21 2018 +0000

    Fixes #4541 (#1) (#4542)

    * Fixes #4541 (#1)

    * Update ISSUE_TEMPLATE.md

commit 25d90ca
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Mon Jan 22 11:26:46 2018 +1100

    Scrips: Update verbiage and comments in `install-node-nvm.sh` script (#4624)

commit 456f28a
Author: Andrew Duthie <aduthie7@gmail.com>
Date:   Sat Jan 20 17:13:37 2018 -0500

    Components: Ensure isLoading set to false after request error (#4525)

commit 5760b63
Author: Ramon <Rahmon@users.noreply.github.com>
Date:   Sat Jan 20 19:33:25 2018 -0200

    Update "Edit Link" to "Insert/edit link" (#4471)

commit d967017
Merge: 62a9e7b 9da45da
Author: Miguel Fonseca <miguelcsf@gmail.com>
Date:   Fri Jan 19 18:36:35 2018 +0000

    Merge pull request #4349 from WordPress/fix/3839-undelayed-slot-prop-update

    fix/3839: Move slot.forceUpdate() to fill's render to fix prop propagation

commit 9da45da
Author: James Johnson <james.johnson@ephox.com>
Date:   Mon Jan 8 16:40:09 2018 +1000

    Move slot.forceUpdate() call into componentWillUpdate

    - Fixes prop propagation across Slot boundary.

commit 62a9e7b
Author: Andrew Duthie <aduthie7@gmail.com>
Date:   Fri Jan 19 12:27:40 2018 -0500

    Block List: Select block only if not already selected (#4586)

commit 8d57578
Author: Andrew Duthie <aduthie7@gmail.com>
Date:   Fri Jan 19 12:24:29 2018 -0500

    Block List: Start multi-selection tracking on mousemove (#4585)

    * Block List: Start multi-selection tracking on mousemove

    * State: Abort state update if multi-select action has no effect

commit d591e58
Author: Ella Van Dorpe <iseulde@automattic.com>
Date:   Fri Jan 19 18:00:06 2018 +0100

    Add subhead block (#2091)

commit 3568fc4
Author: Jorge <jorge.costa@developer.pt>
Date:   Fri Jan 19 16:37:09 2018 +0000

    Added text align feature to cover image. (#4066)

commit 6dd01de
Author: Riad Benguella <benguella@gmail.com>
Date:   Fri Jan 19 14:41:36 2018 +0100

    MetaBoxes: Remove dirty-checking metaboxes state (#4184)

    * MetaBoxes: Remove dirty-checking metaboxes state
    * MetaBoxes: compare meta boxes HTML while leaving the editor to warn about unsaved changes
    * Meta Boxes: Changing the way we save metaboxes
    Hidden metaboxes (side) were not saved before

commit 036f60a
Author: Riad Benguella <benguella@gmail.com>
Date:   Fri Jan 19 14:34:17 2018 +0100

    Blocks: Showing a preview of the block immediately after drag and drop (#4567)

commit 060200c
Merge: df24fd0 0e6fb4b
Author: Miguel Fonseca <miguelcsf@gmail.com>
Date:   Fri Jan 19 11:35:24 2018 +0000

    Merge pull request #4549 from WordPress/add/copy-content-as-extension

    Refactor CopyContentButton as core extension

commit df24fd0
Author: Ella Van Dorpe <iseulde@automattic.com>
Date:   Fri Jan 19 11:57:40 2018 +0100

    Add HTML handler to dropzone (#4577)

    * Add HTML handler to dropzone

    * Add HTML handler to image placeholder

    * Merge ifs

commit 993561d
Author: mac <rileyabrook@gmail.com>
Date:   Thu Jan 18 09:29:19 2018 -0700

    Image Block Link Label Copy Change

commit 5ab37b7
Author: Ella Van Dorpe <iseulde@automattic.com>
Date:   Fri Jan 19 11:12:51 2018 +0100

    Remove "Open in new window" link option (#4583)

    Reverts #2628.

commit 6ed1573
Author: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
Date:   Fri Jan 19 09:49:04 2018 +0100

    Docs: Update title for the scaffolding blocks document (#4596)

commit 91cb16c
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Fri Jan 19 09:47:32 2018 +0100

    Try new icons for movers

    These icons are smaller and less obtrusive, which makes them less heavy to look at.

    This PR also employs a workaround to achieve the effect that `:focusring` would, were it implemented (see https://www.youtube.com/watch?v=ilj2P5-5CjI). This is applied only to the mover icons.

    GIF: https://cldup.com/5lyhf0iSTp.gif

commit f43140e
Author: Riad Benguella <benguella@gmail.com>
Date:   Fri Jan 19 09:44:04 2018 +0100

    Block versioning: Introduce a migration function (#3673)

commit aa5e157
Author: Jason Caldwell <jas@src.works>
Date:   Mon Jan 15 03:28:47 2018 -0900

    Improve `useOnce` documentation.

    #3695

commit 85be4c7
Author: Gary Pendergast <gary@pento.net>
Date:   Fri Jan 19 14:40:26 2018 +1100

    Use docker-compose for all Docker commands (#4592)

commit a2d64e1
Author: Andrew Duthie <aduthie7@gmail.com>
Date:   Thu Jan 18 12:52:56 2018 -0500

    Block: Move drag handling to instance-bound handler (#4582)

commit 0e6fb4b
Author: Miguel Fonseca <miguelcsf@gmail.com>
Date:   Wed Jan 17 15:18:28 2018 +0000

    Refactor CopyContentButton as core extension

    * Use withState & compose, drop class component

    * Cache CopyContentButton element for EditorActions filter

commit 6c256dd
Author: Jorge <jorge.costa@developer.pt>
Date:   Tue Jan 16 21:00:01 2018 +0000

    Don't persist mobile and publish sidebar to localStorage.

    Mobile and publish sidebars should when page reloads, even if they were open before.

commit 4d6af27
Author: Jorge <jorge.costa@developer.pt>
Date:   Tue Jan 16 20:58:46 2018 +0000

    Implemented mechanism to allow reducers to customise what information gets serialised to localStorage; Changed mechanism to load defaults in loadAndPersist.

commit 1fa9344
Author: Jorge <jorge.costa@developer.pt>
Date:   Tue Jan 16 20:43:27 2018 +0000

    Removed old mechanism to avoid mobile sidebar persistence.

    With the last code changes this mechanism is not being used anymore.

commit e24460c
Author: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
Date:   Thu Jan 18 12:37:14 2018 +0100

    Docs: Add page explaining how to scaffold blocks (#4404)

commit b866d21
Merge: 57280d0 d04b78d
Author: Joen Asmussen <joen@automattic.com>
Date:   Thu Jan 18 12:01:35 2018 +0100

    Merge pull request #3996 from WordPress/try/gallery-markup-tweaks

    Try new gallery markup

commit 57280d0
Merge: e97b65f eb954da
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Thu Jan 18 21:41:59 2018 +1100

    Merge pull request #4563 from WordPress/update/eslint-jsdoc

    JSDoc fixes

commit d04b78d
Author: Riad Benguella <benguella@gmail.com>
Date:   Thu Jan 18 11:38:04 2018 +0100

    Gallery Block: Fix tests

commit 91b2504
Author: Riad Benguella <benguella@gmail.com>
Date:   Thu Jan 18 11:26:34 2018 +0100

    Gallery Block: Fix deprecated version

commit 450f716
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Thu Jan 18 11:15:01 2018 +0100

    Try adjusting deprecated attributes

    Also re-add the deprecated CSS class.

commit e97b65f
Merge: f9486f1 5d50586
Author: Joen Asmussen <joen@automattic.com>
Date:   Thu Jan 18 11:13:11 2018 +0100

    Merge pull request #4512 from WordPress/try/new-focus-outlines

    Try new button outline & focus styles

commit 5d50586
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Thu Jan 18 10:59:27 2018 +0100

    Tweak styles further from revert.

commit eb954da
Merge: 968e87f 48780ab
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Thu Jan 18 20:55:46 2018 +1100

    Merge branch 'update/eslint-jsdoc' of github.com:WordPress/gutenberg into update/eslint-jsdoc

commit 968e87f
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Thu Jan 18 20:54:39 2018 +1100

    More JSDoc fixes

commit 1cea78d
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Thu Jan 18 10:53:27 2018 +0100

    Revert tabindex fix, and reverse active & hover states.

commit 48780ab
Merge: 596ff36 f9486f1
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Thu Jan 18 20:24:59 2018 +1100

    Merge branch 'master' into update/eslint-jsdoc

commit 3da0798
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Thu Jan 18 09:49:39 2018 +0100

    Replace all instances of blocks-gallery-image

commit 4466445
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Thu Jan 18 09:29:05 2018 +0100

    Address feedback

    - Move li outside of component
    - Fix CSS typo
    - Add deprecated section

commit d8eaefb
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Thu Dec 14 09:56:47 2017 +0100

    Try new gallery markup

    This is a new version of the PR by #3441 by @samikeijonen. It's just basically "rebased".

    It seems to be working fine in practice, the chief purpose is to make the gallery be list based.

    I'm getting "modified externally" warnings, though.

commit f9486f1
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Thu Jan 18 19:23:33 2018 +1100

    chore: remove `eslines` (#4565)

    * chore: remove `eslines`

    * chore: remove `eslines` from `eslint` npm script

    * chore: remove JSON formatter from `eslint` npm script

commit e9f38ae
Author: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
Date:   Thu Jan 18 09:12:51 2018 +0100

    Components: Force update when new filter added or removed when using withFilters HOC (#4428)

commit cda269d
Author: jaswrks <jaswrks@users.noreply.github.com>
Date:   Wed Jan 17 22:48:30 2018 -0900

    Remove danger warning from plugin header (#4552)

    see: #4185

commit 596ff36
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Thu Jan 18 18:46:05 2018 +1100

    JSDoc fixes

commit e826be5
Author: Lara Schenck <laras126@gmail.com>
Date:   Wed Jan 17 23:33:35 2018 -0800

    Add more context to Templates sample code (#4557)

    * Add function and add_action call to sample code

    * Better function name

commit b8566d7
Merge: 64b6017 c442f0e
Author: Robert Anderson <robert@noisysocks.com>
Date:   Thu Jan 18 09:52:08 2018 +1100

    Merge pull request #4497 from WordPress/update/move-logic-out-of-inserter

    Move data logic out of the inserter

commit c442f0e
Author: Robert Anderson <robert@noisysocks.com>
Date:   Wed Jan 17 16:33:23 2018 +1100

    Add a unique id to inserter items

    This lets the inserter do faster string comparison between inserter
    items rather than deep object comparison.

commit 6759f55
Author: Robert Anderson <robert@noisysocks.com>
Date:   Tue Jan 16 13:00:54 2018 +1100

    Move data logic out of the inserter

    Moves the logic that determines which items should appear in the
    inserter into dedicated selector functions. This way, the logic is
    easier to test and can be re-used.

commit 64b6017
Author: Ella Van Dorpe <iseulde@automattic.com>
Date:   Wed Jan 17 17:18:25 2018 +0100

    Ensure editor still exists after timeout (#4524)

    * Ensure editor still exists after timeout

    * Add doc for setSafeTimeout

commit 0940478
Author: Ella Van Dorpe <iseulde@automattic.com>
Date:   Wed Jan 17 15:24:32 2018 +0100

    Allow copying text in block (non input) (#4531)

commit 79e9552
Merge: add336f d129a6c
Author: Joen Asmussen <joen@automattic.com>
Date:   Wed Jan 17 12:51:28 2018 +0100

    Merge pull request #4313 from WordPress/fix/blinking-focus-outline

    Fix issue where black rectangle would briefly blink on new paragraphs

commit add336f
Author: Riad Benguella <benguella@gmail.com>
Date:   Wed Jan 17 12:23:31 2018 +0100

    Data Module: Expose state using selectors (#4105)

commit 47c36a5
Author: Riad Benguella <benguella@gmail.com>
Date:   Fri Jan 12 14:41:18 2018 +0100

    Meta Boxes: Allow collapsing/sorting the meta boxes panels

commit 8d3a673
Author: Josh Pollock <jpollock412@gmail.com>
Date:   Sat Jan 13 15:30:08 2018 -0500

    Add links to specific sections of Redux docs

    #4452

commit 6e2e944
Author: Robert Anderson <robert@noisysocks.com>
Date:   Wed Jan 17 18:28:48 2018 +1100

    Only minimize -rtl files in production (#4536)

    This improves incremental developmnet build performance by about 3.5x!

commit 9d28bac
Merge: acd3d22 d216fe1
Author: Robert Anderson <robert@noisysocks.com>
Date:   Wed Jan 17 16:59:04 2018 +1100

    Merge pull request #4538 from WordPress/fix/snapshot-tests

    Fix snapshot tests

commit d216fe1
Author: Robert Anderson <robert@noisysocks.com>
Date:   Wed Jan 17 16:51:01 2018 +1100

    Fix snapshot tests

commit acd3d22
Author: Walter Ebert <walterebert@users.noreply.github.com>
Date:   Wed Jan 17 04:24:52 2018 +0100

    Remove Vine embed (#4521)

    Vine is no longer a supported oembed provider since WordPress 4.9.0, it can be removed from Gutenberg to match.

commit c433d76
Author: Gary Pendergast <gary@pento.net>
Date:   Wed Jan 17 13:54:24 2018 +1100

    Improve the build scripts (#4465)

    There's a bunch of stuff that can be automated when setting up a local development environment. Here's some polish, etc.

    Notable changes:

    - Automatically check for and install NVM, update to the correct version of Node.
    - Add some extra information to Docker checks.
    - Add a check and fix for npm/npm#16938, which is super annoying.
    - Switch to using Docker for Composer scripts.
    - Defining the WordPress URL port in docker-compose.yml now defines it everywhere, including Cypress e2e tests.
    - Generally clean up and hide the spammy status messages that don't benefit anyone.
    - Add a welcome message at the end of the setup process.

commit 7f7b607
Author: Helen Hou-Sandi <helen.y.hou@gmail.com>
Date:   Tue Jan 16 17:44:57 2018 -0500

    Insert `@username` for user mention autocomplete (#4444)

    Rather than inserting a static link and the display name, both of which may change over time and lead to stale content, follow the pattern of existing user mentions in WordPress projects and insert a plaintext mention using the username.

commit 2e276ad
Author: Thorsten Frommen <info@tfrommen.de>
Date:   Tue Jan 16 22:27:50 2018 +0100

    Simplify control flow. (#4458)

commit 8cad9ae
Author: Thorsten Frommen <info@tfrommen.de>
Date:   Tue Jan 16 22:25:59 2018 +0100

    Remove stray word. (#4459)

commit fdd1568
Author: Sören Wrede <soerenwrede@gmail.com>
Date:   Tue Jan 16 22:04:58 2018 +0100

    Remove colon from audio and video block placeholder. (#4431)

commit 75d81e9
Author: Andrew Duthie <aduthie7@gmail.com>
Date:   Tue Jan 16 14:53:00 2018 -0500

    Blocks: Reduce sibling inserter initial height (#4384)

commit 3e08d83
Author: Riad Benguella <benguella@gmail.com>
Date:   Tue Jan 16 13:35:21 2018 +0100

    Media: Refactor the MediaUploadButton to be agnostic to its rendered UI

commit 8e87182
Author: Jason Caldwell <jas@src.works>
Date:   Mon Jan 15 04:32:21 2018 -0900

    fix: `applyOrUnset()` consistency.

    See: #3859

commit 8f0aab9
Author: Riad Benguella <benguella@gmail.com>
Date:   Tue Jan 16 14:30:50 2018 +0100

    Documentation: change default post type term

commit b86cbe2
Author: Riad Benguella <benguella@gmail.com>
Date:   Tue Jan 16 14:14:44 2018 +0100

    Documentation: Clarifies how to assign a template to a default Post Type

commit 513534d
Author: Sören Wrede <soerenwrede@gmail.com>
Date:   Tue Jan 16 14:19:33 2018 +0100

    Update copyright year to 2018 in license.md (#4511)

commit 14f76e5
Author: Jb Audras <audrasjb@gmail.com>
Date:   Tue Jan 16 14:01:42 2018 +0100

    Add missing alt attribute to image (and gallery) blocks when alt return an empty value (#4363)

commit 789f955
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Tue Jan 16 13:10:34 2018 +0100

    Polish focus styles further

commit 6c65025
Merge: 64a4cf7 8a12860
Author: Joen Asmussen <joen@automattic.com>
Date:   Tue Jan 16 12:39:20 2018 +0100

    Merge pull request #4508 from WordPress/update/theme-progress-bar

    Update theme progress color bar to match theme

commit 64a4cf7
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Tue Jan 16 22:36:00 2018 +1100

    Remove ESLint JSDoc checks, for now (#4510)

commit 8a12860
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Tue Jan 16 12:01:15 2018 +0100

    Update theme progress color bar to match theme

    This makes it so the animated updater matches the WordPress admin color scheme.

commit 030dec3
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Tue Jan 16 11:38:58 2018 +0100

    Fix focus issue with SVGs

commit adbdbb7
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Tue Jan 16 11:35:57 2018 +0100

    Try a different approach for styling movers

commit db533fa
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Tue Jan 16 11:12:39 2018 +0100

    Try new focus styles

commit f4fb4ad
Author: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
Date:   Tue Jan 16 08:59:59 2018 +0100

    Blocks: Add regression check for block edit using snapshot testing (#4399)

commit 34930ca
Merge: af74fa6 35b8e04
Author: Anton Timmermans <email@atimmer.com>
Date:   Tue Jan 16 08:14:03 2018 +0100

    Merge pull request #4493 from WordPress/update/jsdoc-returns-follow-up

    docs: add preceding line break and remove superfluous spacing in JSDoc `@returns` descriptions

commit 35b8e04
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Tue Jan 16 09:34:20 2018 +1100

    docs: add preceding line break and remove superfluous spacing in JSDoc `@returns` descriptions

commit af74fa6
Merge: 3f54b38 a6b45ad
Author: Robert Anderson <robert@noisysocks.com>
Date:   Tue Jan 16 09:20:47 2018 +1100

    Merge pull request #4395 from WordPress/fix/trigger-typing-mode-on-enter

    Trigger typing mode when ENTER is pressed

commit 3f54b38
Author: Jorge <jorge.costa@developer.pt>
Date:   Mon Jan 15 17:24:48 2018 +0000

    Fixed erros when adding duplicate tags/flat terms. (#4487)

    If we get an error saying we have a duplicate tag/flat term (tag may have been added by other used since last time we fetched), we search the server for the new tag and we add it to our list.

commit 2bdab14
Author: Tammie Lister <tammie@automattic.com>
Date:   Mon Jan 15 11:56:20 2018 +0000

    Added in thrijith as contributor

commit 79bb46e
Author: Thrijith Thankachan <thrijith13@gmail.com>
Date:   Mon Jan 15 17:24:31 2018 +0530

    Video Block: Change block description (#4448)

commit ea36aa5
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Mon Jan 15 19:51:14 2018 +1100

    chore: add `cypress.env.json` to `.gitignore` (#4466)

commit a418f56
Merge: eb468a8 a2e070a
Author: Joen Asmussen <joen@automattic.com>
Date:   Mon Jan 15 09:21:44 2018 +0100

    Merge pull request #4462 from rileybrook/update/conributing.md-workflow

    Update workflow steps in CONTRIBUTING.md documentation

commit eb468a8
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Mon Jan 15 19:21:07 2018 +1100

    chore: remove unused `react-markdown` npm module (#4461)

commit 1e81e41
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Mon Jan 15 19:20:37 2018 +1100

    docs: use `@returns` over `@return` JSDoc tag (#4464)

    Fixes per WordPress JavaScript Inline Coding Standards:

    • Use `@returns` over `@return` JSDoc tag fixing ESLint `jsdoc/check-tag-names` "Invalid JSDoc tag" warnings
    • Ensures there is a blank new line before the `@returns` JSDoc tag
    • Ensures the `@returns` JSDoc tag description ends with a period.

    See https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

commit a6b45ad
Author: Robert Anderson <robert@noisysocks.com>
Date:   Fri Jan 12 12:01:43 2018 +1100

    Trigger typing mode when BACKSPACE is pressed

commit 394c89b
Author: Robert Anderson <robert@noisysocks.com>
Date:   Thu Jan 11 15:50:22 2018 +1100

    Trigger typing mode when ENTER is pressed

    Splitting a block or inserting a new paragraph block by pressing ENTER
    should engage typing mode.

commit a2e070a
Author: mac <rileyabrook@gmail.com>
Date:   Sun Jan 14 19:41:18 2018 -0700

    Update workflow steps in contributing.md documentation

commit 38300ff
Merge: 8ee2b1a 5d4e19d
Author: Robert Anderson <robert@noisysocks.com>
Date:   Mon Jan 15 10:53:43 2018 +1100

    Merge pull request #4304 from WordPress/fix/content-sanitization

    Enable TinyMCE sanitization when setting HTML content

commit 8ee2b1a
Author: Gary Pendergast <gary@pento.net>
Date:   Mon Jan 15 09:04:18 2018 +1100

    Force wp-api.js (via Backbone settings) to use HTTP/1.0 methods only. (#4396)

commit 9fe1ddc
Author: Gary Pendergast <gary@pento.net>
Date:   Mon Jan 15 09:00:10 2018 +1100

    Build Tools: Add support for docker-compose.override.yml (#4457)

    As we don't actually use the `docker` directory to contain anything, the `docker-compose.yml` file has also been moved to the root directory. This tidies up a bunch of commands that used to have to refer to the special file location.

commit ae9b07f
Author: iseulde <ella@iseulde.com>
Date:   Fri Jan 12 17:16:05 2018 +0100

    Remove BR logic from list block

commit 8ac6cc8
Author: Riley Brook <rileyabrook@gmail.com>
Date:   Fri Jan 12 09:37:26 2018 -0700

    Size to Level (#4440)

    Changes copy from "Size" to Level" displayed within Heading block settings.

commit 440d278
Merge: 66303b3 f0b7447
Author: Miguel Fonseca <miguelcsf@gmail.com>
Date:   Fri Jan 12 13:32:04 2018 +0100

    Merge pull request #4429 from WordPress/fix/gutenberg-activation-undefined-constant-warning

    Fix warning plugin activation

commit f0b7447
Author: Miguel Fonseca <miguelcsf@gmail.com>
Date:   Fri Jan 12 13:27:14 2018 +0100

    Fix warning plugin activation

    Guard against undefined constant GUTENBERG_DEVELOPMENT_MODE.

commit 66303b3
Author: Ella Van Dorpe <iseulde@automattic.com>
Date:   Fri Jan 12 13:12:39 2018 +0100

    Image: set width if aligned but unresized (#4356)

commit cd7aa52
Author: Robert Anderson <robert@noisysocks.com>
Date:   Fri Jan 12 23:09:18 2018 +1100

    Fix the Custom Color button from appearing flat (#4392)

    This is a regression caused by #3958.

commit 4d1ad21
Author: Matias Ventura <mv@matiasventura.com>
Date:   Fri Jan 12 12:47:03 2018 +0100

    Increase version to 2.0.0. (#4424)

commit e495f6e
Merge: d937d3a e81ab0a
Author: Miguel Fonseca <miguelcsf@gmail.com>
Date:   Fri Jan 12 12:16:25 2018 +0100

    Merge pull request #4323 from WordPress/update/copy-from-ellipsis

    Ellipsis: Add button to copy entire document

commit d937d3a
Author: Riad Benguella <benguella@gmail.com>
Date:   Thu Jan 11 15:44:41 2018 +0100

    Blocks: Style the "footer" in quotes to ensure backwards compatibility

commit e81ab0a
Author: Miguel Fonseca <miguelcsf@gmail.com>
Date:   Thu Jan 4 19:58:52 2018 +0000

    Ellipsis: Add button to copy entire document

    * Scrap `copyAll` shenanigan, use ClipboardButton

    * ClipboardButton: Accept additional onFinishCopy callback

    * Add component EditorActions below ModeSwitcher

    * Don't close menu on copy, show "Copied!" instead

    * MenuItems: Make it more reusable

    * Allow passing extra `classNames` to MenuItemsGroup, don't require a
    `label`

    * Change classes in MenuItemsToggle from `components-menu-items__toggle`
    to `components-menu-items__button is-toggle`

    * EllipsisMenu: Adopt areas Editor, Settings, Tools

commit 27e6fa8
Author: Stephen Edgar <stephen@netweb.com.au>
Date:   Fri Jan 12 18:43:28 2018 +1100

    Use tabs for indentation in build tools JSON files per WP Coding Standards (#4419)

    * chore: Update `.editorconfig` to match WordPress' upstream

    * chore: Use tabs for indentation in `package.json` and `package-lock.json` files

    * chore: Use tabs for indentation in `.eslines.json` file

    * chore: Use tabs for indentation in `composer.lock` file

commit 9212841
Author: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
Date:   Fri Jan 12 08:18:57 2018 +0100

    Docs: Update info about test fixtures (#4401)

commit d129a6c
Author: Joen Asmussen <asmussen@gmail.com>
Date:   Fri Jan 5 11:21:41 2018 +0100

    Fix issue where black rectangle would briefly blink on new paragraphs

    In master, if you press enter a lot and type a lot, a black rectangle sometimes briefly appears. This is the isEditing rectangle we use to indicate where the cursor is, if it's not in text, i.e. if you have a placeholder selected.

    This PR adds a teensy delay to this so it shouldn't show up.

commit 5d4e19d
Author: Robert Anderson <robert@noisysocks.com>
Date:   Fri Jan 5 11:01:29 2018 +1100

    Enable TinyMCE sanitization when setting HTML content

    We were previously disabling TinyMCE sanitization by calling setContent
    with `{ format: 'raw' }`. Doing so, however, causes issues when
    setContent is called with prettified HTML, e.g. when a list block is
    updated.
@paaljoachim

This comment has been minimized.

paaljoachim commented Jan 26, 2018

Hmm I remember a year or so ago we had a discussion about removing the Open a New Link in the TinyMCE editor but a few of us complained about it and it was in the end not removed.

I noticed the post on make core that Open a New Window link has been removed. I run a tutorial web site and link to a lot of resources at the bottom of my tutorials. I open all the resource links in new windows. So that a person can continue reading the tutorial but have the additional window open to check out some of the resources in a simple way without having to back-fort and having to copy the link to manually open a window. It would be good to have the option in place.
Thanks.

@iseulde

This comment has been minimized.

Member

iseulde commented Jan 26, 2018

I open all the resource links in new windows. So that a person can continue reading the tutorial but have the additional window open to check out some of the resources in a simple way without having to back-fort and having to copy the link to manually open a window.

In that case it should be up to the user to decide that, not you. The user can right click the link and choose "Open in Link in New Tab" or press Cmd while clicking the link (not sure what the Windows equivalent is). If you add target="_blank", you remove the options the user has and force one on them.

@karmatosed

This comment has been minimized.

Member

karmatosed commented Jan 26, 2018

In that case it should be up to the user to decide that, not you. The user can right click the link and choose "Open in Link in New Tab" or press Cmd while clicking the link (not sure what the Windows equivalent is). If you add target="_blank", you remove the options the user has and force one on them.

This is a very important point and takes the power back to the user over hijacking their experience.

@paaljoachim

This comment has been minimized.

paaljoachim commented Jan 26, 2018

Well I made my tutorial site as a kind of online diary of WordPress tutorials mainly for myself but I also like to share them with others. There are some tutorials that just have lots of links to resources and for me it is most useful to have a new browser tab open out to external links.

@ChrisEdwardsCE

This comment has been minimized.

ChrisEdwardsCE commented Jan 29, 2018

A few good reasons as to why this should not be implemented:

  • Link leads to a document or file. If you link to a PDF or MP3 or a different type of file, you most likely want to apply this to open in a new window.
  • Sometimes interruption on a page could cause the loss of a sale. For example, opening terms of service or even a help document.

I feel this is a step backward in the ultimate goal of Gutenberg becoming a "better" option, however, just ads to the issue of too many plugins being added to do something that should be in core. I believe this should be relooked at.

@jb510

This comment has been minimized.

jb510 commented Jan 29, 2018

I fully respect there is a faction that feels target="_blank" is bad and should be purged from the internet. I am one of those people, it's an argument I've had with site owners many many times as they insist they need links to open in a new window.

Here's the problem, this is a valid HTML spec and it is one that individual authors and site owners should rightfully be able to choose to use.

Quite simply you are taking power away from content owners based on your opinion and philosophy.

@iseulde

This comment has been minimized.

Member

iseulde commented Jan 30, 2018

You can still add it and are still free to do so. We won't and shouldn't remove it from the HTML. It's just not part of the default UI.

Link leads to a document or file. If you link to a PDF or MP3 or a different type of file, you most likely want to apply this to open in a new window.

Most likely why?

Sometimes interruption on a page could cause the loss of a sale. For example, opening terms of service or even a help document.

How do you remember to add this to all links in content that is part of a sales page? It sounds again like you'd be better of with a content filter to make sure all links are handled?

@kevinwhoffman

This comment has been minimized.

Contributor

kevinwhoffman commented Jan 31, 2018

There's an underlying assumption that removing the convenience of opening links in new tabs will actually stop people from wanting to open links in new tabs. Users will not suddenly realize that it can be an anti-pattern just because they can't find the control. Furthermore it inconveniences those who do have a legitimate use case for it.

Perhaps most unfortunate is the fact that users will end up manually adding target="_blank" and they will likely be unaware of the security implications if they do not also add rel="noopener noreferrer".

https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/

@webdados

This comment has been minimized.

webdados commented Jan 31, 2018

@jb510 said it all:
"this is a valid HTML spec and it is one that individual authors and site owners should rightfully be able to choose to use.
Quite simply you are taking power away from content owners based on your opinion and philosophy."

@Volnus

This comment has been minimized.

Volnus commented Jan 31, 2018

I am in agreement with @kevinwhoffman just because the option is removed does not mean are not going to want to have links open in another window. There are many use cases where people like to have links open in other windows for instance if they are going to a page to download files, and following a tutorial etc.

By removing the option for target="_blank" as Kevin stated users who are less educated on the topic won't add the proper rel noopener and noreferrer tags possibly leading to security issues.

I think from an editorial and writing perspective the removal of this feature yields no gain, its not improving performance, nor user experience, there is no benefit to removing a commonly used standard that is used quite often.

@webdados

This comment has been minimized.

webdados commented Jan 31, 2018

Sorry for the sarcasm, but this is just a proof that it's possible to turn the "Add link" feature even worst than the one we have since WordPress 4.5.

@notnownikki

This comment has been minimized.

Member

notnownikki commented Jan 31, 2018

My mind has changed on this. People who want to make the new tab happen are going to make it happen anyway. Without this option, they could make it happen in an insecure way.

@alvarogois

This comment has been minimized.

alvarogois commented Jan 31, 2018

I understand the need to give power back to the user. But, in the end, content is being produced by someone, someone that may want to easily decide if a link should or shouldn't open in a new window (and it would be better to do so simply and safely), as it may influence the reading experience – as pointed above. Instead of worshiping the user and punish the bad content creator, maybe we should grant this one the possibility of learning good practices, free will, self-determination.

@iseulde

This comment has been minimized.

Member

iseulde commented Jan 31, 2018

There's an underlying assumption that removing the convenience of opening links in new tabs will actually stop people from wanting to open links in new tabs. Users will not suddenly realize that it can be an anti-pattern just because they can't find the control. Furthermore it inconveniences those who do have a legitimate use case for it.

There's also the assumption that a significant amount of people will want to have this option or will insist on having it. I don't think that's true.

Perhaps most unfortunate is the fact that users will end up manually adding target="_blank" and they will likely be unaware of the security implications if they do not also add rel="noopener noreferrer".

By removing the option for target="_blank" as Kevin stated users who are less educated on the topic won't add the proper rel noopener and noreferrer tags possibly leading to security issues.

That's easily solved by adding a content filter for target="_blank" to add the rel attribute in WordPress Core, which we would need anyway because the user can still remove it from the HTML.

@alvarogois

This comment has been minimized.

alvarogois commented Jan 31, 2018

There's also the assumption that a significant amount of people will want to have this option or will insist on having it. I don't think that's true.

Do you have concrete data on this @iseulde?

@iseulde

This comment has been minimized.

Member

iseulde commented Jan 31, 2018

Do you have concrete data on this @iseulde?

No, but I don't have concrete data on the opposite either.

@notnownikki

This comment has been minimized.

Member

notnownikki commented Jan 31, 2018

That's easily solved by adding a content filter for target="_blank" to add the rel attribute in WordPress Core

Then my issue with it goes away :) It's still possible to have this behaviour, and if we have that content filter, non-technical users won't be making it happen in an insecure way.

@webdados

This comment has been minimized.

webdados commented Jan 31, 2018

Are we removing a feature that WordPress has since it's launch, 15 years ago, (correct me if I'm wrong) based on assumptions and a need to teach the WordPress users a doctrine?

That's easily solved by adding a content filter for target="_blank" to add the rel attribute in WordPress Core, which we would need anyway because the user can still remove it from the HTML.

So, we remove the feature and then we insert filters to make sure that the people that decided they want to use that feature can't do it the wrong way?

@webdados

This comment has been minimized.

webdados commented Jan 31, 2018

non-technical users won't be making it happen in an insecure way

Non-technical users need a GUI.

@alvarogois

This comment has been minimized.

alvarogois commented Feb 1, 2018

I agree that a warning message, if possible, should be included.

I don't agree that this should be considered “a step on the path to eventually removing”. As has been widely debated, not only is this practice very common (with examples of mainstream sites that do it abundantly, Facebook, Medium ...) as there are, indeed, applications that can not be considered, by itself, bad practices.

Inclusion works in many ways. If we (the project) begin to exclude based on a doctrine – the doctrine that states that people expect a link to open in the same page, no matter what –, we're limiting the possibilities of users who don't follow it.

Good practices are not laws written in stone, and it is not up to us to force users to implement them. We should aim for the wider use of our application, and try to follow the best examples, but this should be practiced with the necessary parsimony so as not to exclude those who think differently. That's democracy.

As for the accessibility concern, which is the one that bothers me the most, I wish there was a way to make it compatible with assistive technologies.

@webdados

This comment has been minimized.

webdados commented Feb 1, 2018

The problem with adding a warning message is that we're opening a Pandora box to have warning messages all over the WordPress backend, which has been (correctly) avoided until now.

@afercia

This comment has been minimized.

Contributor

afercia commented Feb 1, 2018

Good practices are not laws written in stone, and it is not up to us to force users to implement them

I'd argue it is not up to us to take control of the users browser 🙂 It has been something like 15 years that browsers have implemented tabbed navigation. Users can open links in a new tab or window whenever they want to do so. As said, there are legitimate cases where target="_blank" makes sense and should be used. That said, I totally agree on the necessary parsimony to use in these cases.

@StaggerLeee

This comment has been minimized.

StaggerLeee commented Feb 1, 2018

Amazed how Gutenberg team can overdo and complicate things. All to "convince" people in their truth.
Make one new GUI option in Link block for target="_blank". And hide it unless activated with prepared filter in functions.php.

People like links opening in new tab or not. In both cases they survive easily. They do not need babysitting.

What is a deal, do not get it ? Are you removing functions.php now too ?

@StaggerLeee

This comment has been minimized.

StaggerLeee commented Feb 1, 2018

And again this obsession with Info messages. Cool for User first 2-3 days, deadly boring next 10 years. And just taking screen space.

If any of you are using browser addons, and I bet most of you do. See in browser top-right part, click on addons icons, and tell Us if you see any Info messages of this sort whatsoever.

@alvarogois

This comment has been minimized.

alvarogois commented Feb 1, 2018

@afercia: we're not talking about the readers, they're not the ones using Gutenberg. We're discussing publishers, the ones that create content. It's up to them to decide if they want to follow good practices and when, not us. Your argument about tabbed browsing and users opening links in new tabs works both ways… In fact, if we believe that people can and know how to open links in new tabs, we must also believe that publishers can and know when to use this option.

@alvarogois

This comment has been minimized.

alvarogois commented Feb 1, 2018

@webdados, I'm inclined to agree with you and @StaggerLeee on the warning message thing.

@StaggerLeee

This comment has been minimized.

StaggerLeee commented Feb 1, 2018

I told them, those things are for question/exclamation mark small icon and modals. As some form fields have Info and explanations. But OK now, offtopic.

@Stiofan

This comment has been minimized.

Stiofan commented Feb 2, 2018

The main argument for removing this seems to be "it should be the users decision" and at the same time this is also being used:

"Every time you give a user an option, you are asking them to make a decision. When a user doesn’t care or understand the option this ultimately leads to frustration. "

Im my experience most website users don't even know how to open a link in a new window which goes against both arguments..

If this is about accessability, maybe the browsers should implement a feature that if a back button is clicked in a new tab it closes the tab...

@webdados

This comment has been minimized.

webdados commented Feb 2, 2018

"(...) When a user doesn’t care or understand the option this ultimately leads to frustration"

Except that everyone that publishes on WordPress know what "Open in new window" is :-)

@Stiofan

This comment has been minimized.

Stiofan commented Feb 2, 2018

That kinda backs up my point, if as u say "everyone" publishing on WP knows what that option is for then again that argument is invalid... what we do know is not everyone using the website knows how to open a link in a new tab, so that argument actually goes againt removing the option.. :)

@maximebj

This comment has been minimized.

Contributor

maximebj commented Feb 2, 2018

Hi, here are my two cents about this :

I'm writing courses. My user follow a pathway from lesson to lesson. I don't want to distract them from this main path, so when I'm linking to another lesson for reference, or another website, it's useful to do it in a new tab to avoid loosing the current pathway.

I'm not sure why there is so much debate here. I've trained more than 500 WordPress beginners, and even if a lot of them encoutered some issues to understand some concepts, neither of them ad trouble understanding the "new tab" option. But only few of them know the CMD+Click shortcut.

I also think than "new tab" is more accurate than "new window".

@webdados

This comment has been minimized.

webdados commented Feb 2, 2018

@Stiofan

that argument actually goes againt removing the option

I know. I'm against it being removed :-)

@2ndkauboy

This comment has been minimized.

Contributor

2ndkauboy commented Feb 2, 2018

I had the same idea as @karmatosed and thinks it's a good solution. We can make sure that if a publisher sets a link to open in a new tab, it's done in a safe way (rel="noopener") and in an accessible way as @afercia has mentioned. Showing a warning is stilla good idea, because too many publishers do open links in new tabs for the wrong reason - in my opinion ;)

@StaggerLeee

This comment has been minimized.

StaggerLeee commented Feb 19, 2018

Just last night became aware you have "open in new tab" option on WordPress support forum.
Who are you kidding, and why. :)

@webdados

This comment has been minimized.

webdados commented Feb 19, 2018

I think this issue is being left dormant and will end up not being resolved. A large number of "day-to-day" WordPress users will not be happy when they realize that this option has been removed.

@jb510

This comment has been minimized.

jb510 commented Feb 19, 2018

I had the same idea as @karmatosed and thinks it's a good solution. We can make sure that if a publisher sets a link to open in a new tab, it's done in a safe way (rel="noopener") and in an accessible way as @afercia has mentioned. Showing a warning is stilla good idea, because too many publishers do open links in new tabs for the wrong reason - in my opinion ;)

I’ve considered this for a couple weeks, done a bit of WCAG reading and my opinion has shifted a little. I still think removing this feature from WP is the wrong direction, but hear me out.

WP should be making publishing accessibly easier for publishers. To me that means giving publishers easy to use tools to be compliant, not taking away tools that don’t comply.

Reading WCAG G200 and G201 it’s clear the guildline is to “warn readers when opening in a new tab”, not “never open in a new tab”.

There should be a warning built in, but not targeted at the publisher saying “don’t do this” the warning should be targeted at the reader. I feel a far surprior solution here would be to make publishers giving readers that WCAG recommended warning easier.

When open in new tab is choosen Gutenberg should automate inserting a visual indicator with tooltip that reads “opens in new window” and insert text in a way that will be read oulpud by screen readers indicating this (see examples on above WCAG links).

As I said before the first principle should be empowering publishers to do things the right way. Removing useful tools only frustrates WP users and perpetuates this myth that WP devs
I’ve in an ivory tower unconcerned with th real day to day needs of publishers. Instead lets build “better decisions” into the tools and make both publishers and readers happier at the same time.

@webdados

This comment has been minimized.

webdados commented Feb 19, 2018

@jb510 while I agree with you that the visitor should be warned, and not the publisher, enforcing this would require loading some JS and/or CSS that would need to be compatible with all the themes out there.

I think this kind of warnings is a browser job, not the website itself. (but I might be wrong, of course)

@Soean Soean referenced this pull request Feb 21, 2018

Closed

Link Target Attributes #5147

@richardkentgates

This comment has been minimized.

richardkentgates commented Feb 21, 2018

This issue has been decided by W3C, which is the governing body of web standards. Dictating the functionality of HTML specifications rather than accommodating the management of these standards is an overreach and outside the scope and intention of any open source platform, including WordPress. If you need clarification or guidance on this issue, I suggest going to the W3C website.

@jb510

This comment has been minimized.

jb510 commented Feb 21, 2018

@richardkentgates wrote:

This issue has been decided by W3C, which is the governing body of web standards. Dictating the functionality of HTML specifications rather than accommodating the management of these standards is an overreach and outside the scope and intention of any open source platform, including WordPress. If you need clarification or guidance on this issue, I suggest going to the W3C website.

This is a completely different topic but it's irked me for years that WP goes about touting powering nearly 1/3 of the internet yet neither the WP Foundation/Org nor Automattic has ever gotten involved in web standards bodies like W3C at all.

@webdados wrote:

@jb510 while I agree with you that the visitor should be warned, and not the publisher, enforcing this would require loading some JS and/or CSS that would need to be compatible with all the themes out there.
I think this kind of warnings is a browser job, not the website itself. (but I might be wrong, of course)

A default could be implemented without JS that themes could then override if they wanted.

Gutenberg markup can insert the hidden span with "opens in new window" test or an icon. Note that an :after pseudo-element would work as well but I don't think screen readers would properly read the content so that doens't work on it's own.

Finally, I agree, this totally seems like a browser's job. I feel markup should be readable, not vocal, but I'm also trying to find a useful compromise that is helpful rather removing useful and heavily used tools.

@richardkentgates

This comment has been minimized.

richardkentgates commented Feb 21, 2018

@jb510 The entire browser experience and the web, in general, is made to accommodate new tabs. Even debating this issue misses the point entirely of tabbed browsing an encourages bloating ISP networks with unnecessary back button clicks. Not too many users on the web are confined to a single-tab environment nor does the average user make use of the context menu for everyday navigation. The idea of a new tab from a link is to expand on a point/idea/article, not replace it, lest you wait for more page loading via the back button. Even debating this is complete tunnel vision (over focus).

10,000 active page viewers + 2,000 back button clicks. Resource burden much?

@paaljoachim

This comment has been minimized.

paaljoachim commented Feb 28, 2018

Btw here is an issue karmatosed made on Jan 18 - Iterations on link interface:
#4572

@StaggerLeee

This comment has been minimized.

StaggerLeee commented Mar 3, 2018

Yesterday I noticed one place where open in new tab would be very desirable. Documentation and Feedback submenus for Gutenberg admin demo menu item. Why navigate away from Gutenberg open edit screen ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment