Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to rename the "Subhead" block #5790

Closed
afercia opened this issue Mar 25, 2018 · 19 comments
Closed

Consider to rename the "Subhead" block #5790

afercia opened this issue Mar 25, 2018 · 19 comments
Assignees
Labels
[Type] Copy Issues or PRs that need copy editing assistance

Comments

@afercia
Copy link
Contributor

afercia commented Mar 25, 2018

As a user, I wouldn't have a clear understanding of what a "Subhead" block is, see #2091. I think this block is really useful for better typography and I really like it. I think in typography its name its name varies, depending on the country and actual usage, sometimes it's called "Summary" sometimes "Lead paragraph" (in my language it has a different name).

Worth considering also translations: not sure there's a suitable translation for "Subhead" in all languages, while "Summary" or "Lead paragraph" are easily translatable.

@afercia afercia changed the title COnsider to rename the "Subhead" block Consider to rename the "Subhead" block Mar 25, 2018
@ZebulanStanphill
Copy link
Member

I agree that "Subhead" is confusing. When I first saw the block I thought it might be for some kind of heading, but when I tried to use it I was confused when it seemed to just be like paragraph. I think something like "Summary" or "Lead Paragraph" would be more clear.

@karmatosed
Copy link
Member

This is interesting as yes I agree that the title does maybe not say what it is, we totally can do better. I think 'Subheading' works: https://dictionary.cambridge.org/dictionary/english/subheading. This seems to say what it does.

@karmatosed karmatosed added the [Type] Copy Issues or PRs that need copy editing assistance label Mar 27, 2018
@afercia
Copy link
Contributor Author

afercia commented Mar 27, 2018

'Subheading' works

Hm not so sure that would work well for translations. Typographic terms vary depending on the culture and language. I'm afraid I don't know what the proper English term is, I've found Intro, Deck, Standfirst, Kicker, Nut Graph, see also the ones mentioned here: http://www.magazinedesigning.com/magazine-page-elements/

In my language, "subheading" would be translated as "Sotto titolo" which means a smaller title under the main title. Instead, this is a paragraph with bigger font size, italic style, meant to be used as an "intro": that's what we call "Sommario" (Summary).

@karmatosed
Copy link
Member

karmatosed commented Mar 28, 2018

As a subheading literally means:

a word, phrase, or sentence that is used to introduce part of a text

That's what this is. Summary or intro means something this isn't, they'd be longer text than this is designed for. Smaller title is exactly what this was originally meant to be, so that actually works. I know it's a balance but lets go with that for now with it being 'Subheading'.

@afercia
Copy link
Contributor Author

afercia commented Mar 28, 2018

As a subheading literally means:

Maybe true in English :) I've tried to explain that would be confusing for translations in other languages, which I think is an important point given WordPress is a global project. Fair enough though.

@karmatosed
Copy link
Member

@afercia I totally agree having words that mean to others in any culture is important. My comment was also based on your stating of what it means in Italian:

In my language, "subheading" would be translated as "Sotto titolo" which means a smaller title under the main title.

Which actually works in this case.

@karmatosed
Copy link
Member

karmatosed commented Apr 18, 2018

I think going for subheading makes sense here at least as a balance between languages. I'll work on a PR for this, thanks.

@karmatosed karmatosed self-assigned this Apr 18, 2018
karmatosed added a commit that referenced this issue Apr 25, 2018
@mrwweb
Copy link

mrwweb commented Apr 30, 2018

I still have some concerns about "subheading" which I think get to a second part of @afercia's OP:

it's called "Summary" sometimes "Lead paragraph"

Subheading could very reasonably be misconstrued for "Heading 2" (the heading "below" the main heading). "Heading", obviously but notably, appears in the word "subheading"!

I do a huge about of education around proper heading usage and this is almost sure to confuse people I've trained. Regardless of what the dictionary definition of "subheading" is, I fear the real-world implications of this choice will lead to misuse of the style.

Most importantly, though, I think the point of OP is that the usage of this style is actually broader than simply a "subheading" and could be used for a full intro paragraph (or "lede" in journalism lingo). Thinking about the common use-cases I run into when responding to user requests for formatting styles, there are two separate requests that this style seems to merge at least in labeling:

  1. A subtitle (i.e. a de-emphasized secondary segment of the page title)
  2. An "Intro Paragraph" (e.g. an emphasized paragraph at the start of an article)

I'd encourage a rethinking of this style's name to reflect that 2nd meaning, especially if the style is to be implemented with a class on a paragraph. (The first time I used this style, I assumed it would be a class applied to a heading.)

@karmatosed
Copy link
Member

I'd totally be up in it being subtitle if everyone agrees.

@mrwweb
Copy link

mrwweb commented Apr 30, 2018

tl;dr - "Subtitle" works but doesn't seem to be an accurate description of the block's current usage.


Is "Subtitle" an accurate description of the block's intent? If so, that immediately raises a number of questions in my mind that don't seem in line with this block (or potentially any block):

  1. Is a paragraph element the most appropriate output? Should it instead be appended to the Heading 1 title inside a <span>? Generally speaking a page's title should be the Heading 1 and a Heading 2 is not appropriate markup for a subtitle.
  2. Should the user be limited to a single Subtitle block on a page? (i.e. If there's only one page title, what does it mean to have multiple subtitles?)
  3. Should the user be limited to having the subtitle block only be the first block? (What does it mean if the subtitle is the last block on the page?)

Depending on some of those answer, a "Subtitle" field feels much more appropriate as a meta-field/setting than a block which can have multiple instances.

I think this kind of this is super important because the name has to communicate the intended use if themes are to be able to design block styles that will make content truly portable. If one theme treats a block as a subtitle but another treats it as "Introduction Text", the user will get confused.

(Also, I don't know (as in, I have no idea about) how translatable "Subtitle" is.)

@karmatosed
Copy link
Member

karmatosed commented Apr 30, 2018

A few of those reasons are why it was called subheading as then it can have more than one use.

a heading given to a subsection of a piece of writing.
"the page is broken up into short paragraphs with sub-headings"

If you look at an example like Google docs, subtitle can be used more than once, as a result I think there is good ground to do that and have it called that. I also think it's fair to have a p and not be a h1 or any other styling. I don't agree this should be a meta setting, it makes a lot of sense to be a block so lets keep it that way in this case.

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Apr 30, 2018

To remove any confusion over which HTML element is semantically correct, here is what the W3C HTML 5.2 specification and W3C HTML 5.3 working draft says:

h1–h6 elements must not be used to markup subheadings, subtitles, alternative titles and taglines unless intended to be the heading for a new section or subsection. Instead use the markup patterns in the §4.13 Common idioms without dedicated elements section of the specification.

From https://www.w3.org/TR/html53/sections.html#the-h1-h2-h3-h4-h5-and-h6-elements

See examples at https://www.w3.org/TR/html53/common-idioms-without-dedicated-elements.html#common-idioms-without-dedicated-elements

It looks like a <p> element is almost always the correct choice for the use cases of the Subhead/Subheading/whatever-it-will-be-called block.

@mrwweb
Copy link

mrwweb commented May 1, 2018

I guess my big concern is that users will use subheadings instead of headings and/or use it for it's visual appearance than as a heading. Headings have an important semantic meaning that provides a page outline for assistive technology and the subhead is a paragraph. That means an unclear name or interface that causes confusion could actively impede people making their content acccessible.

When thinking both about translations and in just one language, it seems the most important thing for any block name is an alignment of:

  1. Page editors' understanding of the intended usage
  2. The semantic output in the source
  3. The likely range of visual displays so that porting content from one theme to another results in an expected output for users

As designed and labels, the text style doesn't scream "subheading" to me, and I'm unclear if that's even an important enough style to justify core inclusion. Knowing users, I'd be shocked if many people don't treat is as a means of text formatting.

It seems like there's just not clarity around the intended purpose of this style, even in the original ticket #2091 that added it where it truly started as a Subtitle. If we can establish the intended use case for the block, then everything else (UI, design, label) should stem from there. One was suggested when this block was added, but things have clearly strayed from there.

I still think an "Introductory Text" style is clearer (meeting all three criteria above) and more useful, but if that's not what people are going for, then I recognize my comments aren't quite relevant.

@aaronjorbin
Copy link
Member

Subtitle
Sweet, that's what I add to my video blocks so they are understandable by people in other languages?

If the goal is for this to be the first paragraph of text and for it to have a slightly different style than the rest of the content, then Dek is the most technically accurate term, but it's also going to be the one that is least likely to be understood.

I'm going to propose something else, let's get rid of this block. Is this a block that we expect 80% of sites to make use of?

gziolo pushed a commit that referenced this issue May 2, 2018
@karmatosed
Copy link
Member

karmatosed commented May 2, 2018

Lots of feedback on this which is great. Thank you for everyone's insights.

Firstly, this block is already one that I've seen people really like, so for now keeping it makes sense. Let's put removing it over into the 'maybe' pile. I'm not ever ruling out any block not making version one.

That said, let's see if we can work through this feedback and get the PR that already was in progress moved on. The thing that right now is holding it up is the naming. Reading the feedback 2 options stand out:

  • Subheading: the original target of the PR.
  • Subtitle: the new suggestion.

@aaronjorbin whilst I understand the point you are making about subtitle (I felt it to initially), this is the name used in other examples like Google. I also agree that 'Dek' right now isn't understood enough to use. As this isn't an option on a video block, I think that confusion can be avoided. It's a standalone block and not related to video.

I see both subheading and subtitle has having pros and cons, all outlined previously. If I had to standby anything I'd say because of the use of subtitle in other applications that for me is the one to change to right now.

@gziolo
Copy link
Member

gziolo commented May 10, 2018

Can we make the final decision and proceed? Both proposals are better than what we have at the moment ...

@karmatosed
Copy link
Member

@gziolo yes, lets go with subtitle on this.

gziolo pushed a commit that referenced this issue May 10, 2018
@karmatosed
Copy link
Member

Because of keyword issues on headings where subtitle is a keyword already, for now lets go with subheading and close this. It is a fairly easy change to iterate on.

gziolo pushed a commit that referenced this issue May 15, 2018
@gziolo gziolo closed this as completed May 15, 2018
@gziolo
Copy link
Member

gziolo commented May 15, 2018

Updated in #6407.

gziolo pushed a commit that referenced this issue May 15, 2018
* Change subhead to say subheading

Try branch for #5790.

* Blocks: Rename subhead to subheading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

No branches or pull requests

6 participants