Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts Library: Fonts modal dialog action buttons accessibility #58083

Closed
afercia opened this issue Jan 22, 2024 · 1 comment · Fixed by #58212
Closed

Fonts Library: Fonts modal dialog action buttons accessibility #58083

afercia opened this issue Jan 22, 2024 · 1 comment · Fixed by #58212
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 22, 2024

Description

In the Fonts modal dialog, the action buttons at the bottom of the dialog offer room for accesisbility improvements.

1
Proximity of controls.
See the related core Trac ticket at https://core.trac.wordpress.org/ticket/40822
Low vision users, users who use screen amgnifiers, etc. struggle to find user interface controls that are places far from each other. In core, over time, we've been fixing several occurrences where buttons or other controls were unnecessarily (and inconsistently) places far from each other.
Also in Gutenberg, most of the instances of action buttons ore other controls that are logically related are places close each other.

Instead, in the Fonts modal dialog, the 'Delete' button and the 'Update' button are places at the opposite bottom corners of the dialog. Screenshot:

proximity

In most of the other modal dialogs buttons are placed close each other, and there's a good reason for that. Example screenshot:

Screenshot 2024-01-22 at 16 46 12

In core, such buttons are placed close each other even when one of the buttons action is a destructive action. Example screenshot:

Screenshot 2024-01-22 at 16 46 48

The buttons in the Fonts modal dialog appeaer to be inconsistent with other UIs in Gutenberg and thei rpalcement is not in line with the best practices established in core.

2
Controls for destructive actions should be red.
As a long established pattern, destructive actions in core use the color red.
I'm not sure why, but the 'Delete' button in this modal dialog is blue. I don't think we should deviate from clear patterns that have been established in core since ages.

destructive

Step-by-step reproduction instructions

  • Go to Site editor > Styles > Typography.
  • Click the 'Aa' icon labeled 'Manage fonts' to open the Fonts modal dialog.
  • Make sure you have at least one custom font installed, e.g. a font installed from Google.
  • Go to the font details sub-view by clicking on its name.
  • Observe at the bottom of the modal dialog the 'Delete' button is blue and it's placed in the bottom left corner, while the 'Update' button is placed in the bottom right corner.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Typography Font and typography-related issues and PRs labels Jan 22, 2024
@matiasbenedetto
Copy link
Contributor

Thanks for reporting this. Here's a potential fix for it: #58212

@afercia afercia changed the title Fonts Library: Fonts modal dialot action buttons accessibility Fonts Library: Fonts modal dialog action buttons accessibility Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants