Font Library: buttons position and accessibility #58212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +16 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
matiasbenedetto
added
[Focus] Accessibility (a11y)
|
Flaky tests detected in 18dc984. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7643044230
|
creativecoder
approved these changes
Jan 24, 2024
afercia
reviewed
Jan 25, 2024
| <CheckboxControl | ||
| checked={ selected } | ||
| onChange={ handleToggleActivation } | ||
| __nextHasNoMarginBottom={ true } | ||
| id={ checkboxId } | ||
| label={ false } | ||
| /> | ||
| <FontFaceDemo fontFace={ face } text={ displayName } /> | ||
| </Flex> | ||
| </label> |
There was a problem hiding this comment.
Unrelated to this PR: it's not okay to associate labels and form controls with both a for attribute and by wrapping the form control within the label element. I do realize the intent is to make the whole row clickable but this is not okay.
I'm surprised the component allows to set the label prop to false.
Also, we do have reusable components for good reasons. One of them is to make sure they're properly labeled. Hardcoding a <label> element around the checkbox component that is supposed to internally handle its label defeats the purpose of having reusable components.
|
Thanks for working on this. I noticed an unrelated problem but I'll open a separate issue. |
afercia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
See #58083 for reference.
Testing Instructions
Screenshots:
Fixes: #58083