Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize capitalization of the term 'navigation menu' #59442

Closed
afercia opened this issue Feb 28, 2024 · 2 comments · Fixed by #60262
Closed

Standardize capitalization of the term 'navigation menu' #59442

afercia opened this issue Feb 28, 2024 · 2 comments · Fixed by #60262
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. [Package] Block library /packages/block-library [Package] Edit Site /packages/edit-site [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Feb 28, 2024

Description

While working on #59431 I noticed the capitalization of the term 'navigation menu' is largely inconsistent across user-facing strings in the editor.

It would be nice to standardize the capitalization.

Searching with the following regex through the codebase: \( '.*navigation menu

21 results - 12 files

packages/block-library/src/navigation/edit/index.js:
  380: 				__( 'Failed to create Navigation Menu.' )
  710: 					{ __( 'Unsaved Navigation Menu.' ) }

packages/block-library/src/navigation/edit/menu-inspector-controls.js:
  105: 				__( 'Structure for navigation menu: %s' ),
  116: 					{ __( 'This navigation menu is empty.' ) }

packages/block-library/src/navigation/edit/navigation-menu-selector.js:
  106: 		selectorLabel = __( 'Choose or create a Navigation menu' );

packages/block-library/src/navigation/edit/use-create-navigation-menu.js:
  88: 					throw new Error( 'Unable to save new Navigation Menu', {

packages/block-library/src/navigation/edit/test/navigation-menu-selector.js:
   92: 		it( 'should show correct dropdown toggle prompt to choose a menu when navigation menus have resolved', async () => {
  304: 		describe( 'Navigation menus', () => {
  425: 			it( 'should call the handler when the navigation menu is selected and disable all options during the import/creation process', async () => {

packages/edit-site/src/components/sidebar-navigation-screen-navigation-menu/delete-modal.js:
  21: 			{ __( 'Are you sure you want to delete this Navigation menu?' ) }

packages/edit-site/src/components/sidebar-navigation-screen-navigation-menu/index.js:
  78: 				description={ __( 'Navigation Menu missing.' ) }
  99: 				description={ __( 'This Navigation Menu is empty.' ) }

packages/edit-site/src/components/sidebar-navigation-screen-navigation-menu/use-navigation-menu-handlers.js:
   38: 			createSuccessNotice( __( 'Deleted Navigation menu' ), {
  107: 			createSuccessNotice( __( 'Renamed Navigation menu' ), {
  162: 				createSuccessNotice( __( 'Duplicated Navigation menu' ), {

packages/edit-site/src/components/sidebar-navigation-screen-navigation-menus/index.js:
   99: 				description={ __( 'No Navigation Menus found.' ) }
  146: 			description={ description || __( 'Manage your Navigation menus.' ) }

packages/editor/src/components/document-bar/index.js:
  40: 	wp_navigation: __( 'Editing navigation menu: %s' ),

test/e2e/specs/editor/blocks/navigation.spec.js:
  289: 			.getByText( 'Navigation menu has been deleted or is unavailable.' );
  293: 	test( 'Adding new links to a navigation block with existing inner blocks triggers creation of a single Navigation Menu', async ( {

test/e2e/specs/site-editor/navigation-editor.spec.js:
  6: test.describe( 'Editing Navigation Menus', () => {

Step-by-step reproduction instructions

See above

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor [Package] Block library /packages/block-library [Package] Edit Site /packages/edit-site labels Feb 28, 2024
@xhemals
Copy link
Contributor

xhemals commented Feb 28, 2024

I can work on this. What is the standardisation wanted? Navigation Menu, Navigation menu, or navigation menu?

@afercia
Copy link
Contributor Author

afercia commented Feb 29, 2024

Usually, in WordPress words are capitalized in two cases:

  • When they are WordPress features, for example: Media Library, Site Health, etc.
  • When they are the labels of buttons or items of the admin menu, for example: Save Changes, Add New Post, Export Personal Data, etc.

There's no such a feature like a 'Navigation Menu' in WordPress. Rather, it's two separate features:

  • Navigation: the block.
  • Menus: the set of items that can be added to a Navigation. For classic Menus, those used to be managed in the admin > Appearance > Menus.

Although they're two separate features, I'd vote for both words capitalized: Navigation Menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. [Package] Block library /packages/block-library [Package] Edit Site /packages/edit-site [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
2 participants