Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise capitalisation of the term 'navigation menu' #59479

Closed

Conversation

xhemals
Copy link
Contributor

@xhemals xhemals commented Feb 29, 2024

What?

Standardising the capitalisation of the term 'navigation menu'

Why?

#59442 Mentions this is an issue with the code base. So this is to fix those inconsistencies

How?

I have ran a replace all command within vscode to replace the outliers in.js .md and .scss and .phpfiles

Copy link

github-actions bot commented Feb 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: xhemals <xhemals@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 29, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @xhemals! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Mar 26, 2024
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @xhemals!

I believe the original issue intends to standardize user-facing labels. I recommend making more targeted changes instead of searching/replacing the whole codebase.

cc @afercia

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs shouldn't include user configurations. Use global git ignore to ignore files specific to your environment.

@afercia
Copy link
Contributor

afercia commented Mar 27, 2024

I believe the original issue intends to standardize user-facing labels. I recommend making more targeted changes instead of searching/replacing the whole codebase.

cc @afercia

Yes in #59442 I suggested to search only within translatable strings that is thte ones that use the i18n functions.
Translatable functions in Gutenberg are __(), _x(), _n(), and _nx() so I suggested a regex to search the codebase \( '.*navigation menu. The syntax may vary depending on the code editor in use. See the internationalization docs.

@xhemals xhemals closed this Mar 27, 2024
@xhemals xhemals force-pushed the update/standardise-capitilisation branch from c715724 to f585b05 Compare March 27, 2024 21:14
@xhemals
Copy link
Contributor Author

xhemals commented Mar 27, 2024

I will re-create a new pull request with the intended changes, rather than how I did things. Apologies for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants