Update standardisation of 'Navigation Menu' to have both words capitalised in user-facing menus #60262
Conversation
…lised in user-facing labels
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @xhemals! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
|
Do I need to update any tests that fail due to my changes? (Couldn't find it in contribution documentation) |
In this case yes, as the test is giving this error: The PR is changing that label to Choose or create a Navigation Menu , so you need to update those labels in the tests too. |
|
UPDATE |
…lised in user-facing menus (WordPress#60262) * Update standardisation of 'Navigation Menu' to have both words capitilised in user-facing labels * Fix capitalization of "Navigation Menus" in tests Co-authored-by: xhemals <xhemals@git.wordpress.org> Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
What?
Fixes #59442
Standardising the capitalisation of the phrase "Navigation Menu" within any user-facing labels.
Why?
#59442 mentions this is an issue with the code base. So this is to fix those inconsistencies on the user-facing labels
How?
Manually reviewed files within
packages/block-library/src/navigation/editto check the capitalisation of the phrase. Any that did not have a capital M or N were changed to this standard.Testing Instructions
Nothing to test as this only changes user-facing labels
Testing Instructions for Keyboard
Screenshots or screencast
One example:
Before
After