Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tips text link border remains on next tip #7452

Closed
karmatosed opened this issue Jun 21, 2018 · 1 comment · Fixed by #7503
Closed

Tips text link border remains on next tip #7452

karmatosed opened this issue Jun 21, 2018 · 1 comment · Fixed by #7503
Assignees
@tofumatt
Labels
[Feature] NUX Anything that impacts the new user experience
Milestone
3.2

Comments

@karmatosed
Copy link
Member

If you click a tip the next one gets the text border around it. Ideally this should reset over having it on all Tips after the one you click.

2018-06-21 at 21 42
@karmatosed karmatosed added this to the 3.2 milestone Jun 21, 2018
@tofumatt tofumatt self-assigned this Jun 22, 2018
@tofumatt tofumatt added the [Feature] NUX Anything that impacts the new user experience label Jun 22, 2018
@tofumatt
Copy link
Member

This appears to have been a deliberate choice to focus the first tab-accessible element in the popover and then fallback to the whole popover itself. I can see the accessibility wins here so that you could keyboard navigate through a few tips at once, but I agree and think just using the fallback is nicer.

tofumatt added a commit that referenced this issue Jun 22, 2018
@tofumatt
fix: Don't focus link in new NUX tooltip (fix #7452)
3cb2680
@tofumatt tofumatt mentioned this issue Jun 22, 2018
Merged
4 tasks
tofumatt added a commit that referenced this issue Jun 27, 2018
@tofumatt
fix: Don't focus link in new NUX tooltip (#7503)
188b679 
* fix: Don't focus link in new NUX tooltip (fix #7452)
* docs: Improve explanation of popover focus
* feat: Add focusFirstElement prop to Popover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Feature] NUX Anything that impacts the new user experience
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

fix: Don't focus link in new NUX tooltip WordPress/gutenberg
2 participants
@tofumatt @karmatosed