Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert link: floating link toolbar for the paragraph block sometimes appears in the wrong place #7992

Closed
talldan opened this issue Jul 17, 2018 · 3 comments · Fixed by #10032
Assignees
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jul 17, 2018

Describe the bug
The popover/popup thing for editing links in paragraph blocks sometimes appears in the wrong place.

To Reproduce
Steps to reproduce the behavior:

  1. Add a paragraph block to a post
  2. Add a link to the paragraph block.
  3. Observe that the edit popover for the correctly link appears underneath the link
  4. Select the post title
  5. Click back into the paragaph block on the link
  6. Observe that the edit popover is in the wrong place

Expected behavior
The popover should appear underneath the link as in step 3.

Screenshots
screen shot 2018-07-17 at 11 28 49 am

Desktop (please complete the following information):

  • Reproduced in Chrome, Mac OS

Additional context

  • Gutenberg 3.2
@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels Jul 17, 2018
@designsimply designsimply changed the title Link edit popover for the paragraph block sometimes appears in the wrong place Insert link: floating link toolbar for the paragraph block sometimes appears in the wrong place Jul 27, 2018
@designsimply
Copy link
Member

Tested and confirmed with WordPress 4.9.8 and Gutenberg 3.6.2 using Chrome 68.0.3440.106 on macOS 10.13.6 and noting I was unable to see the same problem happen using Firefox 61.0.2. (50s)

@designsimply
Copy link
Member

Closed #9246 as a duplicate and noting that the observation in that case is that the floating link toolbar doesn't move properly when clicking between different links in the same paragraph:

Steps to reproduce the behavior:

  1. Create a paragraph with multiple links
  2. Click on one link, then click directly on another without closing the modal
  3. The modal does not move to the second link

switching-between-links-in-paragraphs
Tested at alittletestblog.com running WordPress 4.9.8 and Gutenberg 3.6.2 using Chrome 68.0.3440.106 on macOS 10.13.6.

@arunsathiya
Copy link
Contributor

Noting that I am not able to reproduce this anymore. The popup placement is shown below the selected link, as expected.

I tested for a single link (video) and multiple links placement (video)


Tested on a local install of WordPress. WordPress 4.9.8 and Gutenberg 3.8.0 using Google Chrome Version 69.0.3497.92 (Official Build) (64-bit) on macOS 10.13.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants