-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical terms sorted by name and filterable #10138
Changes from all commits
f31fac9
3612815
280ec07
1be3178
cf14f24
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
.editor-post-taxonomies__hierarchical-terms-list { | ||
max-height: 14em; | ||
overflow: auto; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. scrollable divs need to be made keyboard accessible: only Firefox makes them focusable by default so for other browsers it's necessary to make them focusable and add some ARIA. See for example the Inserter. I'd say something like |
||
} | ||
|
||
.editor-post-taxonomies__hierarchical-terms-choice { | ||
margin-bottom: 8px; | ||
} | ||
|
@@ -25,3 +30,7 @@ | |
margin-top: 8px; | ||
width: 100%; | ||
} | ||
.editor-post-taxonomies__hierarchical-terms-filter { | ||
margin-bottom: 8px; | ||
width: 100%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the search input needs a visible
<label>
element, properly associated with for / id attributes