New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils to the wp-data script dependencies. #10384

Merged
merged 3 commits into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@kopepasah
Member

kopepasah commented Oct 7, 2018

The wp-data inline script relies on window.userSettings.uid, a property set in the utils script.

Fixes #10102

Description

Added utils as a script dependencies for wp-data.

How has this been tested?

Tested locally using WordPress 5.0-alpha-43661 and Gutenberg master with HEAD at 7ec834b77686c6b291ae1ee18fe5860714b58236.

Types of changes

This is a bug fix for #10102.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Add utils to the wp-data script dependencies.
The `wp-data` inline script relies on `window.userSettings.uid`, a property set in the `utils` script.

Fixes #10102

@kopepasah kopepasah requested a review from aduth Oct 7, 2018

Show outdated Hide outdated lib/client-assets.php Outdated
@youknowriad

LGTM 👍 Let's merge when the tests pass.

@youknowriad youknowriad added this to the 4.0 milestone Oct 8, 2018

@youknowriad youknowriad merged commit 96ce333 into master Oct 8, 2018

2 checks passed

codecov/project 49.31% remains the same compared to d316ac5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/10102-uncaught-typeerror branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment