Convert list block to component with bound controls #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incidentally this appears to resolve #916 |
youknowriad
requested changes
Jun 7, 2017
blocks/library/list/index.js
Outdated
| controls={ [ | ||
| { | ||
| icon: 'editor-ul', | ||
| title: wp.i18n.__( 'Convert to unordered' ), |
There was a problem hiding this comment.
aside: should we import those import { __ } from 'i18n';
blocks/library/list/index.js
Outdated
| const { nodeName = 'OL', values = [] } = attributes; | ||
|
|
||
| return [ | ||
| <BlockControls |
There was a problem hiding this comment.
I think you missed the focus check here ;)
There was a problem hiding this comment.
I think you missed the
focuscheck here ;)
How embarrassing considering I'd just remarked on how I'd been okay with it in the previous pull request 😄
aduth
force-pushed
the
fix/919-list-tinymce-attribute
branch
from
462310a
to
ab8523b
Compare
|
Rebased to resolve conflicts and in doing so addressed the two points of feedback. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919
Related: #830
This pull request seeks to update the list block to track internal list type as component state, and the TinyMCE editor instance as an instance property on the class. Previously they were assigned into attributes which would both be serialized, but also caused Redux DevTools to crash the page. It takes advantage of controls rendering introduced in #830 to reference these component instance values in control click handlers.
Testing instructions:
There should be no regression in list behavior.
Confirm you are able to use Redux DevTools extension.