UI Prototype: Add indication that there are more blocks available #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it. Ship it! |
jasmussen
approved these changes
Feb 21, 2017
|
Do you think the gradient should disappear/reappear immediately or with a transition effect? |
It'd be nice if it "lifted off the page" as it became necessary, absolutely! But for the UI prototype, this is definitely good for now. Also on the to-do list is revisiting the inserter entirely — the UI prototype has already shown it to have a couple of weaknesses in its feel. See also: #34. |
nylen
pushed a commit
that referenced
this pull request
Mar 16, 2017
hypest
added a commit
that referenced
this pull request
Nov 2, 2018
…ubdirs Fix eslint missing src subdirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #98
In this small PR, I'm adding a box-shadow when the block menu is scrollable indicating that there are more blocks. The shadow is dropped when we hit the bottom.