Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RichText shortcuts #10901

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fix RichText shortcuts #10901

merged 1 commit into from
Oct 23, 2018

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Oct 22, 2018 •
edited
Loading

Description

Fixes #10883 and adds an e2e test. The problem is a typo.

How has this been tested?

See #10883.

Screenshots

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Oct 22, 2018
@ellatrix ellatrix added this to the 4.1 - UI freeze milestone Oct 22, 2018
@ellatrix ellatrix requested a review from mcsf October 22, 2018 14:45
@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Oct 23, 2018
mcsf
mcsf approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ellatrix
Copy link
Member Author

Thanks!

@ellatrix ellatrix merged commit fe790e5 into master Oct 23, 2018
@ellatrix ellatrix deleted the fix/rich-text-shortcuts branch October 23, 2018 10:01
youknowriad pushed a commit that referenced this pull request Oct 24, 2018
@ellatrix @youknowriad
Fix RichText shortcuts (#10901)
70bb785
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
@ellatrix @antpb
Fix RichText shortcuts (WordPress#10901)
f6b5643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcsf mcsf mcsf approved these changes

Assignees
No one assigned
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.1 - UI freeze
Development

Successfully merging this pull request may close these issues.

Text formatting: Unable to toggle "code" and "strikethrough" formats
2 participants
@ellatrix @mcsf