Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See report in Core: https://core.trac.wordpress.org/ticket/45157
Edit: Superseded by #11375.
See diff with no whitespace changes.
After a lot of back-and-forth, I suspect any failure we may see here is due to interactions caused by Gutenberg-dependent plugins. The
class_exists
guards should be more than enough to allow the plugin to run on both 4.9.8 and 5.0. In any case, we can try to shield the user even more by checking that we're running 4.9.x before loading classes in the plugin.How has this been tested?
Plugin should work in 4.9 and 5.0. Test server-side interactions, like editing Latest Posts, viewing Latest Posts on the frontend. If you have a plugin using server-side knowledge of blocks, try that too.
Note: Latest Comments seems to be having problems in core regardless of the plugin.
Screenshots
Types of changes
Checklist: