Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columns: Improve margins, column child block, mobile. #11904

Merged
merged 5 commits into from
Nov 15, 2018
Merged

Columns: Improve margins, column child block, mobile. #11904

merged 5 commits into from
Nov 15, 2018

Commits on Nov 15, 2018

  1. Columns: Improve margins, column child block, mobile. 

    This PR aims to further improve the columns block, and improving a number of aspects and addressing recent feedback.

- It fixes an issue where fullwide columns had uneven margins, both left, center and right. Fixes #11869.
- It fixes a specificity issue with toolbar and breadcrumb positioning that bled into all child blocks.
- It improves the layout of individual column blocks, and fixes the toolbar positioning. This fixes feedback in #7766 (comment).
- It improves fullwide columns and how they appear on mobile.

Aside from that it simplifies the code a bit, and removes a couple of redundant overrides that were better fixed elsewhere.
    @jasmussen
    jasmussen committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    53ed4c3 View commit details
    Browse the repository at this point in the history

  2. Fix issue with more than 2 columns.

    @jasmussen
    jasmussen committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    446b738 View commit details
    Browse the repository at this point in the history

  3. Prevent columns from growing wider than their set width.

    @jasmussen
    jasmussen committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    dbe5225 View commit details
    Browse the repository at this point in the history

  4. Use break-word for better word breaks.

    @jasmussen
    jasmussen committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    d67d7d5 View commit details
    Browse the repository at this point in the history

  5. Copy editor style to frontend.

    @jasmussen
    jasmussen committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    c67b5c8 View commit details
    Browse the repository at this point in the history