Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a post is saved, check for tinymce and save any editors. #12568

Merged
merged 8 commits into from Dec 9, 2018
Merged

When a post is saved, check for tinymce and save any editors. #12568

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1fa46e4
When a post is saved, check for tinymce and save any editors.
ideadude Dec 3, 2018
7654273
Importing tinymce and using tinyMCE vs the object stored in window.ti…
ideadude Dec 4, 2018
8a1a38b
Updated version number and changelog.
ideadude Dec 4, 2018
55e799d
no longer importing tinymce since we use the tinyMCE global. tinyMCE.…
ideadude Dec 4, 2018
fb38486
Using typeof to check for tinyMCE and fixed issues brought up in trav…
ideadude Dec 6, 2018
4ce7e74
using window.tinyMCE again to avoid warning RE undefined var
ideadude Dec 6, 2018
4a2af66
Restore the package.json version.
youknowriad Dec 9, 2018
04ca775
Add e2e tests for the custom wp_editor metaboxes
youknowriad Dec 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/edit-post/CHANGELOG.md
View file
Open in desktop
@@ -1,3 +1,8 @@
## 3.1.5 (Unreleased)

### Bug Fixes
- Fix saving WYSIWYG Meta Boxes

## 3.1.4 (2018-11-30)

## 3.1.3 (2018-11-30)
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-post/package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "@wordpress/edit-post",
"version": "3.1.4",
"version": "3.1.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "3.1.5",
"version": "3.1.4",

The versions are actually changed automatically when we publish the packages. So we should keep it as is and only update the change log for now

"description": "Edit Post module for WordPress.",
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
Expand Down
5 changes: 5 additions & 0 deletions packages/edit-post/src/store/effects.js
View file
Open in desktop
Expand Up @@ -72,6 +72,11 @@ const effects = {
} );
},
REQUEST_META_BOX_UPDATES( action, store ) {
// Saves the wp_editor fields
if ( typeof( window.tinyMCE ) !== 'undefined' ) {
window.tinyMCE.triggerSave();
}

const state = store.getState();

// Additional data needed for backwards compatibility.
Expand Down