New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Remove redundant core compatibility from plugin #13442

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
2 participants
@aduth
Copy link
Member

aduth commented Jan 23, 2019

Related: #11015

This pull request seeks to remove (deprecated) logic in lib/compat.php assumed to be present in core.

The primary core tracking issue is:

The only remaining compatibility is that of gutenberg_show_privacy_policy_help_text. I could not find an equivalent core compatibility. The one here assumes wrongly that Gutenberg will upgrade the notices, which was removed as part of #12444 . This requires more work. In the meantime, the code in lib/compat.php has been left as-is.

Testing instructions:

Verify there are no regressions in the loading of the editor.

@youknowriad youknowriad referenced this pull request Jan 23, 2019

Open

Remove PHP code merged into WordPress 5.0 #11015

4 of 5 tasks complete

@aduth aduth added this to In Progress in Remove PHP Jan 23, 2019

@aduth

This comment has been minimized.

Copy link
Member Author

aduth commented Jan 25, 2019

The only remaining compatibility is that of gutenberg_show_privacy_policy_help_text. I could not find an equivalent core compatibility. The one here assumes wrongly that Gutenberg will upgrade the notices, which was removed as part of #12444 . This requires more work. In the meantime, the code in lib/compat.php has been left as-is.

In doing some further investigation and in discussing with @desrosj , it's true that this compatibility does not exist. However, the logic lingering here in lib/compat.php does nothing to help, and thus I'm inclined to defer to a core revision to reimplement the notice for the block editor.

To this end, I've created a Trac ticket: https://core.trac.wordpress.org/ticket/46098

As such, I'll plan to include here a deprecation of gutenberg_show_privacy_policy_help_text.

@aduth aduth force-pushed the remove/compat-php branch 2 times, most recently from 3d84d7b to f36ec3e Jan 25, 2019

@aduth aduth force-pushed the remove/compat-php branch from 08c7a6a to c12b401 Jan 28, 2019

@aduth aduth merged commit 3a99ddf into master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 28, 2019

@aduth aduth deleted the remove/compat-php branch Jan 28, 2019

daniloercoli added a commit that referenced this pull request Jan 28, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-move-title-to-rich-text

* 'master' of https://github.com/WordPress/gutenberg:
  Adds undo/redo support for the title. (#13514)
  Fix typo (#13524)
  RichText: List: Fix indent/outdent (#12667)
  Fixes tense on verb “assign” to correct tense (#13541)
  Plugin: Deprecate metabox supports, fall back to core (#13449)
  Rnmobile/upload media file (#13128)
  Plugin: Remove redundant core compatibility from plugin (#13442)
  Testing: Remove PHPUnit tests covering core functions (#13513)
  Plugin: Deprecate gutenberg_add_gutenberg_post_state (#13471)

@aduth aduth added this to the 5.0 (Gutenberg) milestone Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment