Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Formatting fix in MenuGroup Readme #14490

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Minor: Formatting fix in MenuGroup Readme #14490

merged 1 commit into from
Mar 18, 2019

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Mar 18, 2019

Minor followup from #14466, as per notes from @drw158.

Just adds `` around the component name for consistency.

@kjellr
Minor: Formatting fix in MenuGroup Readme
0346e5b 
Adding `` marks around the component name for consistency.

Props @drw158
@kjellr kjellr added [Type] Developer Documentation Documentation for developers Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Mar 18, 2019
@kjellr kjellr self-assigned this Mar 18, 2019
@kjellr kjellr mentioned this pull request Mar 18, 2019
Merged
gziolo
gziolo approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it always helps to add wrap those keywords :)

@gziolo gziolo merged commit 7e5f1d8 into master Mar 18, 2019
@gziolo gziolo deleted the update/menu-group-readme-formatting-fix branch March 18, 2019 12:54
@kjellr
Copy link
Contributor Author

kjellr commented Mar 18, 2019

Thank you!

@gziolo gziolo added this to the 5.4 (Gutenberg) milestone Mar 19, 2019
This was referenced Apr 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@karmatosed karmatosed Awaiting requested review from karmatosed

@davewhitley davewhitley Awaiting requested review from davewhitley

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@kjellr kjellr

Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
5.4 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kjellr @gziolo