New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legacy widget to calendar transform #14586
Merged
jorgefilipecosta
merged 1 commit into
master
from
add/legacy-widget-to-calendar-transform
May 22, 2020
Merged
Add legacy widget to calendar transform #14586
jorgefilipecosta
merged 1 commit into
master
from
add/legacy-widget-to-calendar-transform
May 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
dmsnell,
gziolo,
mkaz,
mmtr,
nerrad,
noisysocks,
oandregal,
notnownikki,
ntwb,
Soean,
swissspidy,
talldan and
youknowriad
as code owners
March 22, 2019 18:59
jorgefilipecosta
force-pushed
the
fix/legacy-call-back-widgets-with-forms
branch
from
March 22, 2019 18:59
123bf60
to
c4c4e14
Compare
jorgefilipecosta
force-pushed
the
fix/legacy-call-back-widgets-with-forms
branch
3 times, most recently
from
April 9, 2019 10:20
0aea34b
to
21f4a7e
Compare
jorgefilipecosta
force-pushed
the
fix/legacy-call-back-widgets-with-forms
branch
6 times, most recently
from
May 2, 2019 13:53
14b7a92
to
b86f9d4
Compare
jorgefilipecosta
added
the
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
label
May 2, 2019
jorgefilipecosta
force-pushed
the
add/legacy-widget-to-calendar-transform
branch
from
May 2, 2019 14:32
89b9de3
to
a777f16
Compare
jorgefilipecosta
changed the base branch from
fix/legacy-call-back-widgets-with-forms
to
update/allow-core-widgets-to-be-used-in-the-legacy-widget-block
May 2, 2019 14:33
jorgefilipecosta
force-pushed
the
update/allow-core-widgets-to-be-used-in-the-legacy-widget-block
branch
3 times, most recently
from
May 27, 2019 21:39
80e48d6
to
72616af
Compare
jorgefilipecosta
added this to Legacy widgets issues/tasks
in Block-based Widgets Editor
May 30, 2019
jorgefilipecosta
added
the
Needs Technical Feedback
Needs testing from a developer perspective.
label
May 30, 2019
jorgefilipecosta
force-pushed
the
update/allow-core-widgets-to-be-used-in-the-legacy-widget-block
branch
from
May 30, 2019 14:56
72616af
to
661a13a
Compare
This needs to be rebased now that #15396 is merged 🙂 |
jorgefilipecosta
force-pushed
the
add/legacy-widget-to-calendar-transform
branch
from
May 20, 2020 19:20
a777f16
to
896f61a
Compare
jorgefilipecosta
requested review from
ellatrix,
karmatosed,
mapk,
SergioEstevao and
TimothyBJacobs
as code owners
May 20, 2020 19:20
jorgefilipecosta
changed the base branch from
update/allow-core-widgets-to-be-used-in-the-legacy-widget-block
to
master
May 20, 2020 19:25
Hi @noisysocks this PR was rebased and is ready for a review. |
noisysocks
approved these changes
May 22, 2020
adamziel
moved this from Legacy widgets issues/tasks
to Done
in Block-based Widgets Editor
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Calendar
Affects the Calendar Block
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
Needs Technical Feedback
Needs testing from a developer perspective.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #15396
Should be merged after the other PR lands.
This PR makes use of the current transforms mechanism to allow transforming legacy widgets containing a calendar into a calendar block.
Testing
I pasted the following block in the code editor:
I was able to transform the legacy widget into a calendar block and also got a heading block with the title.
When I pasted this block and transformed it I only got a calendar:
When I pasted this blocks:
I checked there was no option to convert them into a calendar.