Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy widget to calendar transform #14586

Merged
merged 1 commit into from May 22, 2020

Conversation

jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Mar 22, 2019

Based on: #15396
Should be merged after the other PR lands.

This PR makes use of the current transforms mechanism to allow transforming legacy widgets containing a calendar into a calendar block.

Testing

I pasted the following block in the code editor:

<!-- wp:legacy-widget {"identifier":"WP_Widget_Calendar","instance":{"title":"My calendar"},"isCallbackWidget":false,"hasEditForm":true} /-->

I was able to transform the legacy widget into a calendar block and also got a heading block with the title.

When I pasted this block and transformed it I only got a calendar:

<!-- wp:legacy-widget {"identifier":"WP_Widget_Calendar","instance":{"title":"My calendar"},"isCallbackWidget":false,"hasEditForm":true} /-->

When I pasted this blocks:

<!-- wp:legacy-widget {"identifier":"WP_Widget_Tag_Cloud","instance":{"title":"Tags","count":0,"taxonomy":"post_tag"},"isCallbackWidget":false,"hasEditForm":true} /-->

<!-- wp:legacy-widget {"identifier":"WP_Widget_Archives","instance":{"title":"My archives","count":0,"dropdown":0},"isCallbackWidget":false,"hasEditForm":true} /-->

I checked there was no option to convert them into a calendar.

@jorgefilipecosta jorgefilipecosta force-pushed the fix/legacy-call-back-widgets-with-forms branch from 123bf60 to c4c4e14 Compare March 22, 2019 18:59
@jorgefilipecosta jorgefilipecosta force-pushed the fix/legacy-call-back-widgets-with-forms branch 3 times, most recently from 0aea34b to 21f4a7e Compare April 9, 2019 10:20
@jorgefilipecosta jorgefilipecosta force-pushed the fix/legacy-call-back-widgets-with-forms branch 6 times, most recently from 14b7a92 to b86f9d4 Compare May 2, 2019 13:53
@jorgefilipecosta jorgefilipecosta added the [Feature] Widgets Screen The block-based screen that replaced widgets.php. label May 2, 2019
@jorgefilipecosta jorgefilipecosta force-pushed the add/legacy-widget-to-calendar-transform branch from 89b9de3 to a777f16 Compare May 2, 2019 14:32
@jorgefilipecosta jorgefilipecosta added the [Block] Calendar Affects the Calendar Block label May 2, 2019
@jorgefilipecosta jorgefilipecosta changed the base branch from fix/legacy-call-back-widgets-with-forms to update/allow-core-widgets-to-be-used-in-the-legacy-widget-block May 2, 2019 14:33
@jorgefilipecosta jorgefilipecosta force-pushed the update/allow-core-widgets-to-be-used-in-the-legacy-widget-block branch 3 times, most recently from 80e48d6 to 72616af Compare May 27, 2019 21:39
@jorgefilipecosta jorgefilipecosta added this to Legacy widgets issues/tasks in Block-based Widgets Editor May 30, 2019
@jorgefilipecosta jorgefilipecosta added the Needs Technical Feedback Needs testing from a developer perspective. label May 30, 2019
@jorgefilipecosta jorgefilipecosta force-pushed the update/allow-core-widgets-to-be-used-in-the-legacy-widget-block branch from 72616af to 661a13a Compare May 30, 2019 14:56
@noisysocks
Copy link
Member

This needs to be rebased now that #15396 is merged 🙂

@jorgefilipecosta jorgefilipecosta force-pushed the add/legacy-widget-to-calendar-transform branch from a777f16 to 896f61a Compare May 20, 2020 19:20
@jorgefilipecosta jorgefilipecosta changed the base branch from update/allow-core-widgets-to-be-used-in-the-legacy-widget-block to master May 20, 2020 19:25
@jorgefilipecosta
Copy link
Member Author

Hi @noisysocks this PR was rebased and is ready for a review.

@jorgefilipecosta jorgefilipecosta merged commit 19584dc into master May 22, 2020
@jorgefilipecosta jorgefilipecosta deleted the add/legacy-widget-to-calendar-transform branch May 22, 2020 08:17
@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 22, 2020
@adamziel adamziel moved this from Legacy widgets issues/tasks to Done in Block-based Widgets Editor Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Technical Feedback Needs testing from a developer perspective.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants