Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined drop-cap class #1468

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Fix undefined drop-cap class #1468

merged 2 commits into from
Jun 27, 2017

Conversation

swissspidy
Copy link
Member

Right now when adding a new text block, it gets a drop-cap-undefined class because dropCap is not defined in the block (instead of drop-cap-false I guess). If the drop cap toggle is turned on, there will be a drop-cap-true class.

It makes more sense to only add a drop-cap class if it's enabled and don't do anything else otherwise. You can target non-drop-cap blocks using the :not() CSS selector already.

Plus, drop-cap is more readable than drop-cap-false and drop-cap-true.

@youknowriad
Copy link
Contributor

Should this sync with the "drop cap" updates in #1418?

@swissspidy
Copy link
Member Author

The drop cap changes in #1418 don't touch the same lines as this PR does.

If I rename the class to has-drop-cap in this PR, it could simply go in before the other (which seems to be still in the works).

@mtias
Copy link
Member

mtias commented Jun 27, 2017

Yes, let's update to has-drop-cap. Thanks for fixing.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Jun 27, 2017
@swissspidy swissspidy requested a review from mtias June 27, 2017 11:43
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ship it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants