Change the filtervalue to lowercase

[Jackie6]

Description

Fix #13250

How has this been tested?

• local test
• browser test

Types of changes

Change the filterValue to lower case

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[aduth]

I'm not super familiar with its implementation, but should this be incorporated into what getFilterMatcher is intended to serve? cc @notnownikki re: #10138

[draganescu]

I think this should be treated in the function, not as a quickfix in the function's param. If we look at the getFilterMatcher function this part appears to be the problem:

// If the term's name contains the filterValue, or it has children
// (i.e. some child matched at some point in the tree) then return it.
if ( -1 !== term.name.toLowerCase().indexOf( filterValue ) || term.children.length > 0 ) {
	return term;
}

this condition lowercases the term but allows the filterValue to remain as is. I think it should be::

// If the term's name contains the filterValue, or it has children
// (i.e. some child matched at some point in the tree) then return it.
if ( -1 !== term.name.toLowerCase().indexOf( filterValue.toLowerCase() ) || term.children.length > 0 ) {
	return term;
}

Does this sound right? @Jackie6 @youknowriad

[Jackie6]

Hi @draganescu thanks for your review. I think you are right. It is better to put toLowerCase() functions together.