Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPLv2 LICENSE.md license #1525

Merged
merged 2 commits into from
Jun 28, 2017
Merged

Add GPLv2 LICENSE.md license #1525

merged 2 commits into from
Jun 28, 2017

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Jun 28, 2017

No description provided.

@jasmussen
Copy link
Contributor

Nice, thank you!

Merging.

@jasmussen jasmussen merged commit f20fc91 into WordPress:master Jun 28, 2017
@ntwb ntwb deleted the patch-3 branch June 28, 2017 10:51
@ntwb
Copy link
Member Author

ntwb commented Jun 28, 2017

I expected to now see the license section on the repo frontpage to the right of 45 contributors

Might be caching, if it doesn't appear there in a couple of days, not caching 😏

I don't think it matters if LICENSE.md includes the .md extension or not, time will tell ⌚️

@jasmussen
Copy link
Contributor

I see it:

screen shot 2017-06-28 at 12 57 14

Try in an incognito window.

@swissspidy
Copy link
Member

@ntwb The help page says this:

If your repository is using a license that is listed on the Choose a License website and it's not displaying clearly at the top of the repository page, it may contain multiple licenses or other complexity. To have your license detected, simplify your LICENSE file and note the complexity somewhere else, such as your repository's README file.

So the culprit is 754f233.

@jasmussen He's referring to the top section. It should look like this:

screen shot 2017-06-28 at 12 58 00

@jasmussen
Copy link
Contributor

Oh, my apologies. Hmm.

@ntwb
Copy link
Member Author

ntwb commented Jun 28, 2017

Cool, let's leave it as is then, for background on the 754f233 commit, whilst looking to add a LICENSE.md for the new https://github.com/WordPress/packages repo I came here to pinch Gutenberg's, turns out neither had one, so now both have one 😄

It requested to include the WordPress section via that PR:

WordPress/packages#3 (comment)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants