Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add color options to heading block. #15625
requested review from
May 14, 2019
Do we have a decision here, because I'd rather not introduce something that is going to be removed (it's always hard to remove things when they become APIs)
May 21, 2019
1 check passed
I will follow up with an end 2 end test for this functionality.
We already have a big amount of code reusability, by using shared components for the UI, withColors for the logic, and shared functions. But I agree it is something we could try to improve further. The main decision we would need to do would be the way this reusability would work, the simplest option would be a supports flag for color, but in previous discussions, there was no clear agreement if we should continue investing in support options.