[Mobile] Fix insert list block focus #15698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing it generates a regression where inserting a new list block, the block is not selected
etoledom
added
the
Mobile App - i.e. Android or iOS
1 task
koke
approved these changes
May 17, 2019
|
Thank you! |
koke
added a commit
that referenced
this pull request
May 20, 2019
* Fix rich image caption toolbar and focus (#15685) * RichText: ownProps has precedence over block context. In this way, instances of RichText outside blocks can pass and handle their own custom onFocus and isSelected * RichText: Remove isSelected from block edit context. * Fix lint issues * RichText: Revert removing isSelected from block context (#15698) Removing it generates a regression where inserting a new list block, the block is not selected
hypest
added a commit
that referenced
this pull request
May 20, 2019
* Fix rich image caption toolbar and focus (#15685) * RichText: ownProps has precedence over block context. In this way, instances of RichText outside blocks can pass and handle their own custom onFocus and isSelected * RichText: Remove isSelected from block edit context. * Fix lint issues * RichText: Revert removing isSelected from block context (#15698) Removing it generates a regression where inserting a new list block, the block is not selected * Don't have AztecAndroid set caret if out-of-bounds * Fix lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced by #15685 where inserting a new list block, that block was not automatically focused.
gutenberg-mobileside PR: wordpress-mobile/gutenberg-mobile#994To test: