Testing: Speed up Docker setup on Travis for e2e tests #15748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
aduth,
ajitbohra,
nerrad,
oandregal,
ntwb and
youknowriad
as code owners
gziolo
added
[Type] Automated Testing
gziolo
force-pushed
the
try/faster-travis-env-setup
branch
from
1144b26
to
53a4ea9
Compare
gziolo
force-pushed
the
try/faster-travis-env-setup
branch
2 times, most recently
from
156d8d6
to
108b732
Compare
ntwb
approved these changes
May 21, 2019
aduth
reviewed
May 21, 2019
docker-compose.yml
Outdated
| @@ -2,20 +2,21 @@ version: '3.1' | |||
|
|
|||
| services: | |||
|
|
|||
| wordpress: | |||
| wordpress_dev: | |||
There was a problem hiding this comment.
Can you explain the rename? Is it going to be disruptive to anyone's personal workflows?
There was a problem hiding this comment.
I wanted to better express the intent of this service and make it distinct from the image name. I can revert it now that I confirmrd that everything works
There was a problem hiding this comment.
Reverted in c0836cc. It isn't that important and I share your concern that it might cause some issues.
gziolo
force-pushed
the
try/faster-travis-env-setup
branch
from
108b732
to
c0836cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some improvements to the performance of Travis jobs as part of #15159.
The main difference in this proposal is that we no longer pull, create and start containers that are never used on Travis. This applies for jobs which run e2e tests and PHP unit tests.
It's very easy to notices that there is a huge gain on some of the jobs where they finish even 2-3 minutes faster!!!
Aside: I also tried to remove
npm ciandnpm run buildfrom the jobs which run PHP unit tests but it turned out that it's still necessary for some tests to pass. See #15159 (comment) for more details.How has this been tested?
Travis should pass all checks.