Build: Skip downloading Chromium when building plugin's zip #15886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Build Tooling
gziolo
requested review from
aduth,
ajitbohra,
nerrad,
oandregal,
ntwb and
youknowriad
as code owners
nerrad
approved these changes
May 29, 2019
|
https://github.com/typicode/husky/blob/d931c3ea878604759c4fc1ba2cd5aee2b68f1c7c/DOCS.md#disable-auto-install - @aduth, Husky can also be disabled conditionally on both Travis and in the updated script, what do you think? |
It self-detects Travis and automatically disables (you can see in the logs of any Travis task). Seems reasonable for the packaging script, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simple change should speed up the process of doing releases. It skips downloading Chromium which is only required when running e2e tests.
Before:
After:
Testing
npm run package-pluginor fork Gutenberg, change thegitRepoOwnerinbin/commander.jsconstant to your handle and run./bin/commander.js rc.