Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Skip downloading Chromium when building plugin's zip #15886

Merged
merged 1 commit into from May 29, 2019

Conversation

@gziolo
Copy link
Member

commented May 29, 2019

Description

This simple change should speed up the process of doing releases. It skips downloading Chromium which is only required when running e2e tests.

Before:
Screen Shot 2019-05-29 at 12 46 59

After:
Screen Shot 2019-05-29 at 13 14 19

Testing

npm run package-plugin or fork Gutenberg, change the gitRepoOwner in bin/commander.js constant to your handle and run ./bin/commander.js rc.

@nerrad

nerrad approved these changes May 29, 2019

Copy link
Contributor

left a comment

well that seems simple enough!

@youknowriad
Copy link
Contributor

left a comment

Nice

@gziolo

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

https://github.com/typicode/husky/blob/d931c3ea878604759c4fc1ba2cd5aee2b68f1c7c/DOCS.md#disable-auto-install - @aduth, Husky can also be disabled conditionally on both Travis and in the updated script, what do you think?

@gziolo gziolo added this to the 5.9 (Gutenberg) milestone May 29, 2019

@gziolo gziolo merged commit 93a1cdf into master May 29, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@gziolo gziolo deleted the update/build-plugin-zip branch May 29, 2019

@aduth

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@aduth, Husky can also be disabled conditionally on both Travis and in the updated script, what do you think?

It self-detects Travis and automatically disables (you can see in the logs of any Travis task).

https://github.com/typicode/husky/blob/d931c3ea878604759c4fc1ba2cd5aee2b68f1c7c/src/installer/index.ts#L167-L170

Seems reasonable for the packaging script, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.