Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts: Document and simplify changing file entry and output of build scripts #15982

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Scripts: Document and simplify changing file entry and output of build scripts #15982

merged 1 commit into from
Jun 14, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jun 4, 2019 •
edited

Description

Closes #14891.

The build and start commands supports simplified syntax for multiple entry points:

$ npx wp-scripts build entry-one.js entry-two.js --output-path=dist

In fact, you could call:

$ npx wp-scripts build entry-one=./entry-one.js entry-two=./entry-two.js --output-path=dist

as of today to achieve the same but it might take some time to experiment to discover it.

This proposal makes public API less tied to webpack and gives a way to map it to another tool in the future. In addition, it makes it simple to provide entry points by doing all the mapping behind the scenes.

Testing

Two entry points in src folder built into build folder

Create two JS files in src folder:

  • entry-one.js
  • entry-two.js
 $ npx wp-scripts build src/entry-one.js src/entry-two.js

This should output four files:

  • build/entry-one.js
  • build/entry-one.deps.json
  • build/entry-two.js
  • build/entry-two.deps.json

Custom entry points and custom output folder

Create two JS files in the root folder:

  • entry-one.js
  • entry-two.js
 $ npx wp-scripts build entry-one.js entry-two.js --output-path=dist

This should output four files:

  • dist/entry-one.js
  • dist/entry-one.deps.json
  • dist/entry-two.js
  • dist/entry-two.deps.json

@gziolo gziolo added [Type] Enhancement A suggestion for improvement. [Package] Scripts /packages/scripts labels Jun 4, 2019
@gziolo gziolo self-assigned this Jun 4, 2019
@gziolo gziolo force-pushed the update/custom-file-entry-output branch 2 times, most recently from 1279c88 to 682d919 Compare June 5, 2019 12:14
@gziolo gziolo added this to the 5.9 (Gutenberg) milestone Jun 5, 2019
@gziolo gziolo marked this pull request as ready for review June 5, 2019 12:26
@gziolo gziolo mentioned this pull request Jun 5, 2019
Closed
@nerrad nerrad removed this from the Gutenberg 5.9 milestone Jun 10, 2019
@gziolo gziolo requested a review from a team June 13, 2019 14:24
youknowriad
youknowriad approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gziolo gziolo force-pushed the update/custom-file-entry-output branch 2 times, most recently from 405163a to 4ff786e Compare June 14, 2019 10:42
@gziolo gziolo force-pushed the update/custom-file-entry-output branch from 4ff786e to 0d7624a Compare June 14, 2019 10:46
@gziolo gziolo added this to the Gutenberg 6.0 milestone Jun 14, 2019
@gziolo gziolo merged commit dcd0041 into master Jun 14, 2019
@gziolo gziolo deleted the update/custom-file-entry-output branch June 14, 2019 11:08
daniloercoli added a commit that referenced this pull request Jun 14, 2019
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
ef88999 
…rnmobile/open-video-by-browser-for-android

* 'master' of https://github.com/WordPress/gutenberg: (34 commits)
  [RNMobile] Native mobile release v1.7.0 (#16156)
  Scripts: Document and simplify changing file entry and output of build scripts (#15982)
  Block library: Refactor Heading block to use class names for text align (#16035)
  Make calendar block resilient against editor module not being present (#16161)
  Bump plugin version to 5.9.1
  Editor: Fix the issue where statics for deprecated components were not hoisted (#16152)
  Build Tooling: Use "full" `npm install` for Build Artifacts Travis task (#16166)
  Scripts: Fix naming conventions for function containing CLI keyword (#16091)
  Add native support for Inserter (Ported from gutenberg-mobile) (#16114)
  docs(components/higher-order/with-spoken-messages): fix issue in example code (#16144)
  docs(components/with-focus-return): fix typo in README.md (#16143)
  docs(block-editor/components/inspector-controls): fix image path in README.md (#16145)
  Add mention of on Figma to CONTRIBUTING.md (#16140)
  Bring greater consistency to placeholder text for media blocks. (#16135)
  Add descriptive text and a link to embed documentation in embed blocks (#16101)
  Update toolbar-text.png (#16102)
  Updating changelogs for the Gutenberg 5.9 packages release
  chore(release): publish
  [RNMobile] Fix pasting text on Post Title (#16116)
  Bump plugin version to 5.9.0
  ...

# Conflicts:
#	packages/block-library/src/video/video-player.android.js
This was referenced Jul 16, 2024
Open
Open
@OKEAMAH OKEAMAH mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@oandregal oandregal Awaiting requested review from oandregal

@ntwb ntwb Awaiting requested review from ntwb

Assignees

@gziolo gziolo

Labels
[Package] Scripts /packages/scripts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 6.0
Development

Successfully merging this pull request may close these issues.

Scripts: Allow changing file entry and output of build scripts
3 participants
@gziolo @youknowriad @nerrad