New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds dimension controls to Group Block #16730
Commits on Feb 24, 2020
-
-
Moves Dim Control to block editor package. Makes size class based rat…
…her than hard coded value
-
-
Addresses #16730 (comment) Renames `type` to `property` to better indicate that it is a formal CSS property value and therefore should not be translated lest it break the underlying code. Added title attribute to enable true text-based strings to be translatable.
-
-
-
-
-
-
-
-
Update to decouple DimensionControl component from knowledge of Block…
… attribute schema Previously the `DimensionControl` component manually constructed the attribute to be updated via string concatenation. This was brittle and prone to error and also couple the component to use in a Block context. Updated to utilise partial application to apply the dimension attribute argument in advance for each component. This allows us to simply the API of the component.
-
Utilise withInstanceId HOC to remove need for id prop
Also updates tests to account for this.
-
Updates size buttons for improved comprehension and a11y
Updates `N` to be `No`. Also avoids string manipulation approach to getting visual size button label in favour of explicit abbr prop on sizes.
-
Remove duplicate Dimension Control
This was handled in a separate PR and resides in `@wordpress/components`. Can be removed from this PR.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-