Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dimension controls to Group Block #16730

Closed
wants to merge 43 commits into from

Commits on Feb 24, 2020

  1. Copy the full SHA
    1567db0 View commit details
    Browse the repository at this point in the history
  2. Moves Dim Control to block editor package. Makes size class based rat…

    …her than hard coded value
    getdave committed Feb 24, 2020
    Copy the full SHA
    b072dd6 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    e75ac86 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    851272d View commit details
    Browse the repository at this point in the history
  5. Improve i18n of strings.

    Addresses #16730 (comment)
    
    Renames `type` to `property` to better indicate that it is a formal CSS property value and therefore should not be translated lest it break the underlying code.
    
    Added title attribute to enable true text-based strings to be translatable.
    getdave committed Feb 24, 2020
    Copy the full SHA
    e8ea617 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    cca7e68 View commit details
    Browse the repository at this point in the history
  7. Adds reset button to UI

    getdave committed Feb 24, 2020
    Copy the full SHA
    dbd6cdb View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    0574e47 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    672c51b View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    d59d196 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    e63ed10 View commit details
    Browse the repository at this point in the history
  12. Adds doc blocks

    getdave committed Feb 24, 2020
    Copy the full SHA
    4babcb6 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    f26ad45 View commit details
    Browse the repository at this point in the history
  14. Adds basics tests

    getdave committed Feb 24, 2020
    Copy the full SHA
    11b476c View commit details
    Browse the repository at this point in the history
  15. Adds component docs

    getdave committed Feb 24, 2020
    Copy the full SHA
    7d92083 View commit details
    Browse the repository at this point in the history
  16. Update to decouple DimensionControl component from knowledge of Block…

    … attribute schema
    
    Previously the `DimensionControl` component manually constructed the attribute to be updated via string concatenation. This was brittle and prone to error and also couple the component to use in a Block context.
    
    Updated to utilise partial application to apply the dimension attribute argument in advance for each component. This allows us to simply the API of the component.
    getdave committed Feb 24, 2020
    Copy the full SHA
    45f7aa1 View commit details
    Browse the repository at this point in the history
  17. Utilise withInstanceId HOC to remove need for id prop

    Also updates tests to account for this.
    getdave committed Feb 24, 2020
    Copy the full SHA
    d1b3aa8 View commit details
    Browse the repository at this point in the history
  18. Updates size buttons for improved comprehension and a11y

    Updates `N` to be `No`. Also avoids string manipulation approach to getting visual size button label in favour of explicit abbr prop on sizes.
    getdave committed Feb 24, 2020
    Copy the full SHA
    5d5d198 View commit details
    Browse the repository at this point in the history
  19. Copy the full SHA
    d30b760 View commit details
    Browse the repository at this point in the history
  20. Copy the full SHA
    f94a15e View commit details
    Browse the repository at this point in the history
  21. Remove duplicate Dimension Control

    This was handled in a separate PR and resides in `@wordpress/components`. Can be removed from this PR.
    getdave committed Feb 24, 2020
    Copy the full SHA
    28ca9b4 View commit details
    Browse the repository at this point in the history
  22. Copy the full SHA
    8d41a49 View commit details
    Browse the repository at this point in the history
  23. Removes Dimension Control docs

    This was automated.
    getdave committed Feb 24, 2020
    Copy the full SHA
    9923154 View commit details
    Browse the repository at this point in the history
  24. Copy the full SHA
    cc3277b View commit details
    Browse the repository at this point in the history
  25. Copy the full SHA
    ad7325b View commit details
    Browse the repository at this point in the history
  26. Copy the full SHA
    325c45a View commit details
    Browse the repository at this point in the history
  27. Copy the full SHA
    08d1dee View commit details
    Browse the repository at this point in the history
  28. Removes responsive setup

    getdave committed Feb 24, 2020
    Copy the full SHA
    3f9579a View commit details
    Browse the repository at this point in the history
  29. Copy the full SHA
    4095617 View commit details
    Browse the repository at this point in the history
  30. Add margin and i18n

    getdave committed Feb 24, 2020
    Copy the full SHA
    e200219 View commit details
    Browse the repository at this point in the history
  31. Copy the full SHA
    44575ec View commit details
    Browse the repository at this point in the history
  32. Copy the full SHA
    223ee9a View commit details
    Browse the repository at this point in the history
  33. Update snapshots.

    getdave committed Feb 24, 2020
    Copy the full SHA
    fd3741f View commit details
    Browse the repository at this point in the history
  34. Copy the full SHA
    3c96458 View commit details
    Browse the repository at this point in the history
  35. Copy the full SHA
    9ad9c74 View commit details
    Browse the repository at this point in the history
  36. Remove unwanted help text

    Implements feedback from #16730 (comment)
    getdave committed Feb 24, 2020
    Copy the full SHA
    e849702 View commit details
    Browse the repository at this point in the history
  37. Copy the full SHA
    af88337 View commit details
    Browse the repository at this point in the history
  38. Copy the full SHA
    3f516ae View commit details
    Browse the repository at this point in the history
  39. Remove random new line

    getdave committed Feb 24, 2020
    Copy the full SHA
    7678379 View commit details
    Browse the repository at this point in the history
  40. Copy the full SHA
    a9bed02 View commit details
    Browse the repository at this point in the history
  41. Adds help text to controls

    getdave committed Feb 24, 2020
    Copy the full SHA
    0a6eec9 View commit details
    Browse the repository at this point in the history
  42. Copy the full SHA
    cec67bf View commit details
    Browse the repository at this point in the history
  43. Copy the full SHA
    f6ec10c View commit details
    Browse the repository at this point in the history