Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clear floats on specific successive blocks that use alignment tool #16780

Open
wants to merge 3 commits into
base: master
from

Conversation

@obenland
Copy link
Member

commented Jul 26, 2019

Description

Rebased PR #13819, fixing conflicts with master.
See #13819 (comment)

Fixes #13819.
Fixes #13784.

How has this been tested?

In local environment, adding images and floating them around.

Types of changes

Adds a CSS selector to clear center-aligned images.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
codetipi and others added 3 commits Feb 11, 2019
Fixes 13784
Improves frontend/backend consistency of floats. Themes (Including Twentynineteen) generally clear blocks with center alignment if they come straight after a block with left/right float.

To recreate:

1- Add two blocks with alignment options, such as the Image block.
2- Set first block to align to left/right and set second block to align to center.
3- Second block should be 100% the width and clear the float from the first block.
// Center
&[data-align="center"] {
clear: both;
}

This comment has been minimized.

Copy link
@youknowriad

youknowriad Aug 1, 2019

Contributor

I still have the same question, not sure if it was answered. This behavior only applies to the editor, do we want to apply the same behavior in the frontend too?

This comment has been minimized.

Copy link
@senadir

senadir Sep 9, 2019

Contributor

it makes sense to have the same behavior right?

This comment has been minimized.

Copy link
@youknowriad

youknowriad Sep 10, 2019

Contributor

It does for me 🤷‍♂ but maybe we're expecting the theme to define that?

@paaljoachim

This comment has been minimized.

Copy link

commented Sep 9, 2019

This would be a PR that would be great to get as soon as possible into Gutenberg and core, as floats and alignment issues still need fixing.

@obenland or others.
Can we get an update to where this PR is at at the moment? From the above it seems almost ready for the last code review and then merge.

EDIT: Obenland told me that he does not have the time to work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.