Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Add section about updating package after new releases #17026

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@gziolo
Copy link
Member

commented Aug 13, 2019

Description

This PR adds a new section explaining how to update @wordpress/scripts package after new releases. I noticed that create-react-app has this section in their repository I thought that we should include it as well. See https://create-react-app.dev/docs/updating-to-new-releases for reference. I mostly included the same instructions.

It also contains some editorial changes to make things clearer.

You can preview the updated version here:
https://github.com/WordPress/gutenberg/blob/6c7ff15f2742b9dc405b82c42d38c7fd74ffa3bd/packages/scripts/README.md

gziolo added 2 commits Aug 13, 2019
It also contains some editorial changes to make things clearer
Copy link
Member

left a comment

I'm really only qualified to review this from an end-user perspective, but from that perspective it LGTM :)

@ntwb
ntwb approved these changes Aug 13, 2019
@ntwb ntwb merged commit a94e907 into master Aug 14, 2019
43 checks passed
43 checks passed
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@ntwb ntwb deleted the update/docs-wp-scripts branch Aug 14, 2019
gziolo added a commit that referenced this pull request Aug 29, 2019
* Scripts: Add section about updating package after new releases
It also contains some editorial changes to make things clearer

* Use one version of apostrophe
gziolo added a commit that referenced this pull request Aug 29, 2019
* Scripts: Add section about updating package after new releases
It also contains some editorial changes to make things clearer

* Use one version of apostrophe
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
…ress#17026)

* Scripts: Add section about updating package after new releases
It also contains some editorial changes to make things clearer

* Use one version of apostrophe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.