Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Add section about updating package after new releases #17026

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Aug 13, 2019

Description

This PR adds a new section explaining how to update @wordpress/scripts package after new releases. I noticed that create-react-app has this section in their repository I thought that we should include it as well. See https://create-react-app.dev/docs/updating-to-new-releases for reference. I mostly included the same instructions.

It also contains some editorial changes to make things clearer.

You can preview the updated version here:
https://github.com/WordPress/gutenberg/blob/6c7ff15f2742b9dc405b82c42d38c7fd74ffa3bd/packages/scripts/README.md

@gziolo gziolo self-assigned this Aug 13, 2019
@gziolo gziolo added [Type] Developer Documentation Documentation for developers [Package] Scripts /packages/scripts labels Aug 13, 2019
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really only qualified to review this from an end-user perspective, but from that perspective it LGTM :)

@ntwb ntwb merged commit a94e907 into master Aug 14, 2019
@ntwb ntwb deleted the update/docs-wp-scripts branch August 14, 2019 00:34
gziolo added a commit that referenced this pull request Aug 29, 2019
* Scripts: Add section about updating package after new releases
It also contains some editorial changes to make things clearer

* Use one version of apostrophe
gziolo added a commit that referenced this pull request Aug 29, 2019
* Scripts: Add section about updating package after new releases
It also contains some editorial changes to make things clearer

* Use one version of apostrophe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants