Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block-calendar: Use 400 as a valid font-weight #17047

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Aug 15, 2019

Description

Reported via #WP47881:

W3C CSS Validator results for .wp-block-calendar table th in wp-includes/css/dist/block-library/style.min.css?ver=5.2.2:

Value Error : font-weight 440 is not a font-weight

Standart font-weight property: [https://www.w3.org/TR/2018/REC-css-fonts-3-20180920/#font-weight-prop]

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ntwb ntwb added the [Block] Calendar Affects the Calendar Block label Aug 15, 2019
Copy link
Contributor

@brentswisher brentswisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! I checked and I cannot see any visual difference between 400 and 440 weight, so I am thinking the value likely got set to 440 as a typo more than an intentional choice. @jorgefilipecosta was the original developer on this block - unless he sees some reason not to I will merge later this week.

Possibly worth noting that CSS Fonts Level 4 extends the syntax to accept any number between 1 and 1000 https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight but I don't think that this needs to be set to 440 regardless.

@brentswisher brentswisher merged commit da0b1a3 into master Aug 21, 2019
@brentswisher brentswisher deleted the update-font-weight branch August 21, 2019 18:10
@brentswisher brentswisher added this to the Gutenberg 6.4 milestone Aug 21, 2019
@brentswisher
Copy link
Contributor

I went ahead and merged this, thanks again @ntwb for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants