Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: Repeated documentation file designers-developers/designers/menu-item.md #17286

Merged

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 31, 2019

The most up to date documentation file for MenuItem is located at

https://github.com/WordPress/gutenberg//blob/3550aad006ac58feccdfc94c75422e95a10d14d6/packages/components/src/menu-item/README.md

The only component documented in docs/designers-developers/designers/ is this one and the documentation is not updated. Nothing links to this file I think we should not keep this file there the documentation for this component should be at /packages/components/src/menu-item/README.md following what we do for all the other components.

@mkaz
mkaz approved these changes Aug 31, 2019
Copy link
Member

left a comment

Good catch, I don't see it linked anywhere else either.
👍

@talldan talldan merged commit 8213431 into master Sep 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the remove/repeated-docs-file-from-designers-developers branch Sep 2, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.