Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix navigation block menu alignment #17630

Merged
merged 5 commits into from Oct 1, 2019
Merged

Fix navigation block menu alignment #17630

merged 5 commits into from Oct 1, 2019

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Sep 27, 2019 •
edited

Closes #17540

default-menu-edit-style

  • Menu items and nested menu items within a Navigation block should be aligned properly.
  • Nested menu items should only be shown when the parent menu item is selected.

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Sep 27, 2019
@draganescu draganescu self-assigned this Sep 27, 2019
@draganescu draganescu added this to In Progress in Navigation editor Sep 27, 2019
@noisysocks noisysocks changed the title Wip: default style for editing nav block Fix navigation block menu alignment Sep 30, 2019
noisysocks
noisysocks reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! With this change the Navigation block is really starting to take shape 🙂

packages/block-editor/src/components/block-list/block.js Outdated Show resolved Hide resolved
noisysocks
noisysocks requested changes Sep 30, 2019
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I meant to request changes!

noisysocks
noisysocks approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous! 👍

@draganescu draganescu merged commit 2927ee7 into master Oct 1, 2019
@draganescu draganescu deleted the update/default-style-nav-block branch October 1, 2019 05:56
@noisysocks noisysocks removed this from In Progress in Navigation editor Oct 14, 2019
@youknowriad youknowriad added this to the Gutenberg 6.7 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@draganescu draganescu

Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 6.7
Development

Successfully merging this pull request may close these issues.

Navigation block: Fix menu item alignment
3 participants
@draganescu @noisysocks @youknowriad