Fix for bug with toggling opensInNewWindow state #17794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the opensInNewWindow state is not toggled in InlineLinkUI if both the activeAttributes.url and activeAttributes.target props both change - in this case only the url change is reflected in the component state due to getDerivedStateFromProps returning before the opensInNewWindow check is hit
How has this been tested?
Tested manually as follows:
Also added a unit test to check that state.opensInNewWindow is set when props.activeAttributes.target _blank passed in.
Types of changes
Fixes #17770
Checklist: