Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for bug with toggling opensInNewWindow state #17794

Merged
merged 3 commits into from Oct 7, 2019
Merged

Fix for bug with toggling opensInNewWindow state #17794

merged 3 commits into from Oct 7, 2019

Commits on Oct 6, 2019

  1. Update getDerivedStateFromProps to pass back all state property changes

    Glen Davies committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    af7f907 View commit details
    Browse the repository at this point in the history

  2. Add test to check that state.opensInNewWindow is set correctly on pro… 

    …p change
    Glen Davies committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    c3a6014 View commit details
    Browse the repository at this point in the history

  3. Rename test file

    Glen Davies committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    7dbe80d View commit details
    Browse the repository at this point in the history